From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 581774BAFF for ; Wed, 2 Jul 2025 04:26:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6C6F768DCE3; Wed, 2 Jul 2025 07:25:39 +0300 (EEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 946BD68DCE2 for ; Wed, 2 Jul 2025 07:25:32 +0300 (EEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-234d366e5f2so55523685ad.1 for ; Tue, 01 Jul 2025 21:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751430330; x=1752035130; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PKaGNUVjiWxf1BWcS0NVXHOLO98xx0+j1YAnhCZnaUo=; b=RkN46Rfeg3Sof6q/RJmBp4ItSAm0XRPsq6hmG45vocwUE4LUcDPzUSVSaxkoiQwdxr 5itEJ6xODF+hoMIEcRKHMdJazBw1QQ7OrXTX9CPLw6pPlt2R8SzH7KX241Z3fZtlt/sJ b3qcaR1rAHalefVY8q0Q2X9fjspYhBNc6m4JyKjGHR9+gFMiXL1qTwwbgMxbwk+mogzX blf4JLLb8GxvQcjp9qvEIR7fZBf8TovKHrj/gTX5GsKe6w9+QbU0YY7GUQxbgM2+f/QT 51whXZAvJ59Mr4BdOp/Rz1yoaAzaHlaF3aCGzFn0pA8FIf736GCM3Uywc00SOuCTTgXn upyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751430330; x=1752035130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PKaGNUVjiWxf1BWcS0NVXHOLO98xx0+j1YAnhCZnaUo=; b=maKHTw28Jx/VZo0KpjdUQrwT1noi3k06qrRSeGcWosNoIqc86k0Wf5yCCwIAM9dzj9 jtO6yw8ZH6A/pR9gRNraXWgkyClZWwFI5zgBKmHZ4wSUJctI5SZqJvEUwTjkwSYJnvRx Uu/p2TIwMyxpp7xHF6GKGQtKdfHmhXwd134BDYXyaEM6V4iJRjhl/2UwSj/uGkIkRCYg Hkzq7r1Wutj0Rx13plbwTLIoVyCPdr8HCExzn5LP3wsvx8YV9UCdtWmVVgG7GOcNLq0n Kg8NHBYbHf8FMqahWzIqc5S38upYsHy1C2+MWaLCbfraOCb1E+X/ib5F4Tl/Kzd1nsFz EwQA== X-Gm-Message-State: AOJu0YwUYXNeKrZTLn6Cppvp7vCU8lnWWeerFp+G7QVdJSk6ea9AufFc Z1ty8FRg20BIrCL4EViEACav5Gv4Oz1cfst8/g8fHzMqfllPxSojhAox/Xjt0rrlITCs7A== X-Gm-Gg: ASbGncu9mP8KU1A/sQ9krtluFzQjLK/HjEG2HwnpJx/aHsdyBh2ufXkh+hBpJD/BtkX EO01HvlJirH7FKbGhapOAgsPqcf8htDVBDp4413VMMPhiOHAyn54Ayhz9Nz5rBdmFZmlQBBkR2z zACHWp2FwbRPaWua0BWshNyRcPQ0cfVlzi3MOt18OyGBSJn5zZDiPQPEBXImi4kVeABJy77eLnZ NH/JeqCRImUQmTkhSQv9nGt1xY9esnwgFzJBTxL6mtGCahL0Kmlrc1uCD5/YDZIPYkkdtUoPXL5 iO4lUBRc6zBlSoGPjsrj+URC7uUIATbyuBIu8rGErN8yGSptWva9bvU2tLwtYVn7HQ== X-Google-Smtp-Source: AGHT+IE1q7L5LoLli+ZY7KXE5o6RPHi3iMRURR5wLyIab/XzFwPIqQeSARge831nIQm5tQ/rmhzD9Q== X-Received: by 2002:a17:902:ce8d:b0:234:b123:b4ff with SMTP id d9443c01a7336-23c6e502d8emr24711185ad.21.1751430330627; Tue, 01 Jul 2025 21:25:30 -0700 (PDT) Received: from localhost.localdomain ([5.34.218.76]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e258csm127670575ad.38.2025.07.01.21.25.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 01 Jul 2025 21:25:30 -0700 (PDT) From: Jack Lau X-Google-Original-From: Jack Lau To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Jul 2025 12:25:04 +0800 Message-ID: <20250702042505.72292-6-jacklau1222@qq.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250702042505.72292-5-jacklau1222@qq.com> References: <20250702042505.72292-1-jacklau1222@qq.com> <20250702042505.72292-2-jacklau1222@qq.com> <20250702042505.72292-3-jacklau1222@qq.com> <20250702042505.72292-4-jacklau1222@qq.com> <20250702042505.72292-5-jacklau1222@qq.com> MIME-Version: 1.0 X-Unsent: 1 Subject: [FFmpeg-devel] [PATCH 5/6] WHIP: X509 cert serial number should be positive. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: winlin , Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: winlin See RFC5280 4.1.2.2 Co-authored-by: winlin Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a3905891d..4733faec9c 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -316,7 +316,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); + // According to RFC5280 4.1.2.2, The serial number MUST be a positive integer + serial = (int)(av_get_random_seed() & 0x7FFFFFFF); if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".