From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EF0E04B6E8 for ; Mon, 30 Jun 2025 00:41:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AC0BD68DD76; Mon, 30 Jun 2025 03:41:31 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CCB4E68DA3B for ; Mon, 30 Jun 2025 03:41:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E1F2C43B17 for ; Mon, 30 Jun 2025 00:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1751244084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8hSv8FoZtBt+i/IdxyF7cniGgpK4nzveyhj2JmcCzaI=; b=fKO+MXZU8xdz8Jm0zvz8cvUmi+o8cEMB9vQP3z/NHyocKp7M0JUXJSctrrDbNFz3Oc66AC 2OcVuuSe+FJ0CR0L+bMUkuSUJ9yk4ksByJyK60kgW+C+xtkKYwxhw1S7jBV/N/4KBtfDqI IPaniFjcc4pR2byJ0oZaTDKZMZ/nQx0cnHsOJ2MWCSXBAqxVuK80ES1xdLcFgZUuLqovTA 1wOoMFcRDEINhldi6m/WMo34iGBi6jVoFTon+P0tXD5Uf8wrToWnefMnnwDrkZ8wIz1/AF Vxc69POFtS8jp+bCaqAiucFAAwp/VyPirH5MTlHAb0IrnUT+ASp3ibZNs3uxvA== Date: Mon, 30 Jun 2025 02:41:22 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250630004122.GW29660@pb2> References: <2C68074A-F28F-42DB-8346-E65A80F7DB6F@gmail.com> <2BA2B6A2-A0EE-491A-8651-99C9EE1641F9@gmail.com> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -44 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddutddvkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegoufhushhpvggtthffohhmrghinhculdegledmnegfrhhlucfvnfffucdljedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeevjeduueejfefhudeugeehtdelkeevgfehvdegkeekkeejtdefkedthffgjedvieenucffohhmrghinhepghhoohhglhgvrdgtohhmnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov.c: Fix to allow custom udta tags through when export_all option specified. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5916640249613149836==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5916640249613149836== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BcdezSraLkRoJRv1" Content-Disposition: inline --BcdezSraLkRoJRv1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 29, 2025 at 09:42:27AM +1200, Ken McGaugh wrote: > On Sun, 29 Jun 2025 at 08:33, Ken McGaugh wrote: >=20 > > On Sun, 29 Jun 2025 at 7:44=E2=80=AFAM, Baptiste Coudurier < > > baptiste.coudurier-at-gmail.com@ffmpeg.org> wrote: > > > >> Hey Ken > >> > >> > On Jun 28, 2025, at 1:04=E2=80=AFAM, Ken McGaugh = wrote: > >> > > >> > On Sat, 28 Jun 2025 at 13:52, Baptiste Coudurier < > >> > baptiste.coudurier-at-gmail.com@ffmpeg.org >> baptiste.coudurier-at-gmail.com@ffmpeg.org>> wrote: > >> > > >> >> Hi > >> >> > >> >>> On Jun 27, 2025, at 5:46=E2=80=AFPM, Ken McGaugh wrote: > >> >>> > >> >>> Hi, first time contributing to ffmpeg so I hope I got this right. = We > >> use > >> >>> custom udta tags in our pipeline but they were not coming through > >> >>> correctly. Looks like they were incorrectly being routed through t= he > >> code > >> >>> path for "raw" data. > >> >>> --- > >> >>> libavformat/mov.c | 2 +- > >> >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >>> > >> >>> diff --git a/libavformat/mov.c b/libavformat/mov.c > >> >>> index bd6b23466b..1b17f52a16 100644 > >> >>> --- a/libavformat/mov.c > >> >>> +++ b/libavformat/mov.c > >> >>> @@ -484,7 +484,7 @@ retry: > >> >>> return ret; > >> >>> } > >> >>> } else return 0; > >> >>> - } else if (atom.size > 4 && key && !c->itunes_metadata && !ra= w) { > >> >>> + } else if (atom.size > 4 && !c->itunes_metadata && !raw) { > >> >>> str_size =3D avio_rb16(pb); // string length > >> >>> if (str_size > atom.size) { > >> >>> raw =3D 1; > >> >>> -- > >> >>> 2.39.5 (Apple Git-154) > >> >> > >> >> Thanks! > >> >> Would it be possible for you to share a small sample? > >> >> > >> >> > >> > Certainly. Here is a sample .mov with a handful of custom udta atoms. > >> For > >> > example, the '[169]tco' one should have the value "FrameNumber", but > >> > without this patch it is exported as an empty string. > >> > > >> > > >> https://drive.google.com/file/d/1KJgRueP26cuo1os2OaNqBz2u8-aeUbBS/view= ?usp=3Dsharing > >> > > >> > >> Thanks! > >> I feel we should do "if (atom.size > 4 && (key || c->export_all) && > >> !c->itunes_metadata && !raw=E2=80=9D to be safer. > >> What do you think ? > > > > > > That would definitely be safer. Thanks for catching that. Do you need me > > to submit an updated patch? > > >=20 > Here it is in case you need it from me. Thanks again for your prompt revi= ew. >=20 > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/mov.c b/libavformat/mov.c > index bd6b23466b..31ebcebca1 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -484,7 +484,7 @@ retry: > return ret; > } > } else return 0; > - } else if (atom.size > 4 && key && !c->itunes_metadata && !raw) { > + } else if (atom.size > 4 && (key || c->export_all) && > !c->itunes_metadata && !raw) { > str_size =3D avio_rb16(pb); // string length theres a linebreak corrupting the patch, check your editors word / line wra= p settings or attach patches thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB For a strong democracy, genuine criticism is necessary, allegations benefit noone, they just cause unnecessary conflicts. - Narendra Modi --BcdezSraLkRoJRv1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaGHdLAAKCRBhHseHBAsP q3fIAJ0TeLHefQBr6XqaQJ3nNyyqqxgTqACfXafstgw0tHmO9jd9uokRo5YJoaI= =MJ1M -----END PGP SIGNATURE----- --BcdezSraLkRoJRv1-- --===============5916640249613149836== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5916640249613149836==--