From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8F9AD4CF42 for ; Sun, 29 Jun 2025 06:45:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EF55268D215; Sun, 29 Jun 2025 09:45:45 +0300 (EEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E11EA68BB4E for ; Sun, 29 Jun 2025 09:45:36 +0300 (EEST) Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-748f5a4a423so757171b3a.1 for ; Sat, 28 Jun 2025 23:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751179535; x=1751784335; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ZwF0xbLvD9EHYjFl4PIsDtodcUcevVl8g5PG/6hG5U=; b=OXG0rNlnultHpoM2StVnk3N1o2UeSWOHfFoO7YR2Ca3cjFgpRtr5yW3rzOj1X/JNK3 ZJ5KfrH2yAMYQiVtfc/9H0wSvJneJne1vabfs5le5oO7+o6AA5NT3RslaFoPQEijvrp8 3sCOH9IyopPlJhf1OQGzZszeN++nrxUWIm9uBMd3BwwYPsIlsAJ+93gK3h+o9Glx9jPM 2pkIxnqHeR21oIRfI+4Ensb3Ps1Z+5TUxmjaofphiJhiabfrTNcEW6jE8w4MVq69SQs7 tHN5wD2X6TPBS5fTfD2D35SwsN+GcaY/6BweP/SshOGafmEumqiXPnU0OBM1LEnhKBlC n6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751179535; x=1751784335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ZwF0xbLvD9EHYjFl4PIsDtodcUcevVl8g5PG/6hG5U=; b=U+uqROraocMok6g18Kk216sJ2AXJosPtY4pXlxccRdQYD99JyfPO6JSqtp6i99aH4i sLF4ZaJvOrSFQpGy/jzJWlOFa6pD0/Vkqgt3aTuHhBrf13DOBImcEfGg8Jq+h1fj9Gw1 6qb5IcbrP1vtoVqjCMK9U2A+f1bxUg2tgx+8pfyjqL80FAm/HjNoYSQNIqq2s2frHMJK ughqsXz+W0QgiFh1UjbcQu43CUPa/1+yRDzgVMwZ9+JwcVWJNTfU3kuDiKgd/mJDIC1g 76sD+LXvvbPQinfWDNMrHCWeAhWyta/vUmKeCv2XxCyZoYhmzp2f3OTcUC9C0chCNzHw DrWA== X-Gm-Message-State: AOJu0YyFzcLvxRRUn8juq+THgMdjp2NR8HQbVXLChE0NWaq34LowOgOx RvazvmEcKSH9FulRwb+XbL4DU4qry/ZVa6MWwdPqG5jHtREbbohp8xEJGIVTU6pI/gzaSQ== X-Gm-Gg: ASbGncsjHwnQf0QkUqP6G0dt0mjOWBVIPvJEpXj4bpRgCKZnVTi2GGCdZhKNyjeRViB q/U7gzo9gtguCGeMeM6Hmm6HldWieud7P04M1x2kbE+u18YSiOY91xcfJ0lRB2Ah42KQ59GGW9b XZL2amIuyMK09+dIbBMOIxAcq0T0iIsNbj26arlRERI3doqqS296g5uhBaEIA5UnXX0dob8QlOt s0XX2mBouUatk1T+18Rz67dpjsBJOwjKQJrU/qGi3TgFO6hNIxhAnnaz9eC0voQBG6a8KVHjfUh g0TipwkycYDdym7G495Eb4dRhzFvFkqDDUf+WC/fI+q+V/Ux7MVADBExt7OYMwE5QxL5 X-Google-Smtp-Source: AGHT+IGyoSfpg9SKaNNZrSOlSuvewzOoicxIGVqYRIlUln1dB3soRvOXkuusYcUn9qcUDEhmoctD6Q== X-Received: by 2002:a05:6300:6c16:b0:21a:ecf5:ea71 with SMTP id adf61e73a8af0-220a12a906cmr8315624637.15.1751179535091; Sat, 28 Jun 2025 23:45:35 -0700 (PDT) Received: from r760 ([188.253.126.204]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b34e3200fedsm5178086a12.73.2025.06.28.23.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Jun 2025 23:45:34 -0700 (PDT) From: Lidong Yan X-Google-Original-From: Lidong Yan <502024330056@smail.nju.edu.cn> To: ffmpeg-devel@ffmpeg.org Date: Sun, 29 Jun 2025 14:45:22 +0800 Message-ID: <20250629064526.2992143-2-502024330056@smail.nju.edu.cn> X-Mailer: git-send-email 2.50.0.106.gf0135a9047.dirty In-Reply-To: <20250629064526.2992143-1-502024330056@smail.nju.edu.cn> References: <20250629064526.2992143-1-502024330056@smail.nju.edu.cn> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: fix leaks in decode_plane() and decode_plane10() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lidong Yan <502024330056@smail.nju.edu.cn> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In decode_plane() and decode_plane10(), both of these two functions use build_buff() which allocates memory in vlc and multi. And both of them forget to release vlc and multi when build_buff report a symbol to fill slices with. Add cleanup label and goto cleanup first before return 0. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> --- libavcodec/utvideodec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 4c0fa2ca67..f15d623462 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideodec.c @@ -179,7 +179,7 @@ static int decode_plane10(UtvideoContext *c, int plane_no, dest += stride; } } - return 0; + goto cleanup; } send = 0; @@ -216,6 +216,7 @@ static int decode_plane10(UtvideoContext *c, int plane_no, "%d bits left after decoding slice\n", get_bits_left(&gb)); } +cleanup: ff_vlc_free(&vlc); ff_vlc_free_multi(&multi); @@ -322,7 +323,7 @@ static int decode_plane(UtvideoContext *c, int plane_no, dest += stride; } } - return 0; + goto cleanup; } src += 256; @@ -361,6 +362,7 @@ static int decode_plane(UtvideoContext *c, int plane_no, "%d bits left after decoding slice\n", get_bits_left(&gb)); } +cleanup: ff_vlc_free(&vlc); ff_vlc_free_multi(&multi); -- 2.50.0.106.gf0135a9047.dirty _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".