Re: [FFmpeg-devel] [FATE PATCH] Properly list test errors when there are no failed tests

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1811 bytes --]

Hi Martin

On Fri, Jun 27, 2025 at 03:43:58PM +0300, Martin Storsjö wrote:
> On Wed, 18 Jun 2025, Michael Niedermayer wrote:
> 
> > Hi Martin
> > 
> > On Fri, Jun 13, 2025 at 01:57:05PM +0300, Martin Storsjö wrote:
> > > If there were failures while running tests, e.g. if failing to
> > > compile checkasm or any other of the test programs, there are no
> > > failed tests per se, and the number of succeessful tests is
> > > equal to the total number of tests.
> > > 
> > > For these cases, check the job status code instead of declaring
> > > them as a full success.
> > > ---
> > >  history.cgi | 2 +-
> > >  index.cgi   | 2 +-
> > >  report.cgi  | 6 +++++-
> > >  3 files changed, 7 insertions(+), 3 deletions(-)
> > 
> > sounds reasonable, but ill leave the perl review to someone who actually
> > knows perl
> 
> I've tested it locally, so if we have nobody else volunteering to review it,
> is that enough?

yes


> 
> > Its a few years since the last change to fateserver, i think we dont
> > have a script to update the checkout on the server from a git push.
> > Its a while, i dont remember exactly :)
> > so you have to update that checkout after pushing possibly
> 
> I don't think I have access to any such server,

I think you do, i see a ssh-rsa key for martin@sphere for
fate@fate.ffmpeg.org


> but if it's ok with you can
> I (try to) push this patch to the gitosis repo,

yes, we use gitolite not gitosis though


> and then ask some admin
> (Timo?) to possibly update a checkout somewhere.

sure

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".