From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id ADB984CC6F for ; Fri, 27 Jun 2025 14:14:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D305068D30A; Fri, 27 Jun 2025 17:14:44 +0300 (EEST) Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3E46E68CF41 for ; Fri, 27 Jun 2025 17:14:38 +0300 (EEST) Received: by mail-qv1-f67.google.com with SMTP id 6a1803df08f44-6fac7147cb8so36804436d6.1 for ; Fri, 27 Jun 2025 07:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751033676; x=1751638476; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6unPFW6paBMq37rl8TmOBdD8UBLgeVRbY1aKfAQs2FU=; b=Au1oEEW0MDjb7GBXxbxjWh9RqyRtLTZh9/2pYtN3ZWtPEHnOlrdxzBakiNywvDhPFX zGCcl+JXuKHleCyeaCLOfm981WBUe3qPf43owiAEd5GOHOOH1D4qnNkMbCrUVjWxbEh3 VSZGBaWn7mXj+7da98d1iyXMpkvrA9LnvLZK9mK80rOr+9G8Xzm8HzxZJkSWRVCIOhog zcMN8Tcd8YpLf6fMnWkQE5GcmKqxAYu4jNEorMA/pvKaCQ6LGMjhH8nQRPnVWYij4DUu VSw63y35uPZ35NZjUoIUDlM0PVd2ugboNhXbjEirRTSpRaoxLVOaBvExmc0Yx7AEoTNQ 6jvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751033676; x=1751638476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6unPFW6paBMq37rl8TmOBdD8UBLgeVRbY1aKfAQs2FU=; b=hi4rG2j3gGOXdXkpu3DKIJsomifFJITJyfHbGfzTPqgYL1WshzBgICVXwDME7og8M8 FLpV5x8f5bbPNbCeTdsmkUVZ/Rhruio0b5NAwvJUXhbg3SkvlnWh5DCvLUAPFTzzy0s0 AdO7Sp9URYxsY/Aq1389iYEyRKyNSqyIq01DUW9CqvkNafjLkmLhG/lEMzm4snpRVy7l J7dZy2IbhuaqlBMU3zzkCBqAR378d1qPPuZ4R8O7MrSkq32LM+WkJwNGBbPR/94C+LCx I7uA1Y+siguA1/KbppDJZFhfhO4sDg5hkUMkyGnt1+NUsDKH7+oVMHz7Q9iScLBMOaoB OBbg== X-Gm-Message-State: AOJu0YwG9//OmsslI1+wncO82rcqpnobdXQldm7/DDphVECh2lpuI2AT 0lLHYROVoteA9ixST6kgDLyMcu7n1Q04Z53pv+iCh/lLOFyzBSaDObrqxF9oFVGVFUR5GQ== X-Gm-Gg: ASbGncsYVBrpnzlRxG8s24YXUq5lMGuhnSVM5iX0GgKoFIIPr/8Ymg+rWfSE4epP72N bjR5g+x7VyL/9Uc6pYKzuiKJhSvUy/kt9CCsGM4NbSpmKnRtEi01zi1V8a/rts2b2n1RLYzayoU EabBubpf+waOusMZnZu333CCqjnPKQtqex4Wp9a9LQ8F6SWEf/tBTOZSWb4ChIMdX5yqJFzJMlc DIPXMrdeinZccqjwp1l/loxZCI/DiQ+7Kp2ITeUSMLKRy1/oRFEmsHvnO3Ts+0DMCnFISuLZiMU ZNRYIuHM+6NFoJ/P4pMuM9bUwsrC0x+e7F/lssv9Jxo6aqEDsInNYq1Iy67EEKxpzJbd X-Google-Smtp-Source: AGHT+IG3ERCeeG/Uum6Ya7hgkVoxSwHVpHZ4u38eZHP1sUdpGmwHp4G4pS3qOrOAZio5HtOltAoODQ== X-Received: by 2002:a17:902:e54b:b0:234:9068:ed99 with SMTP id d9443c01a7336-23ac468217cmr61274565ad.24.1751033371854; Fri, 27 Jun 2025 07:09:31 -0700 (PDT) Received: from r760 ([188.253.126.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb3c1d3csm18007685ad.207.2025.06.27.07.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 07:09:31 -0700 (PDT) From: Lidong Yan X-Google-Original-From: Lidong Yan <502024330056@smail.nju.edu.cn> To: ffmpeg-devel@ffmpeg.org Date: Fri, 27 Jun 2025 22:09:16 +0800 Message-ID: <20250627140918.2832152-3-502024330056@smail.nju.edu.cn> X-Mailer: git-send-email 2.50.0.108.g6ae0c543ae In-Reply-To: <20250627140918.2832152-1-502024330056@smail.nju.edu.cn> References: <20250627140918.2832152-1-502024330056@smail.nju.edu.cn> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/vorbisenc: fix leak if av_mallocz failed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lidong Yan <502024330056@smail.nju.edu.cn> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In put_main_header(), av_mallocz() allocates memory to local variable buffer, buffer leaks if av_mallocz() to *out failed. Add av_free(buffer) before return error code. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> --- libavcodec/vorbisenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 99ac72c910..b4680a11ed 100644 --- a/libavcodec/vorbisenc.c +++ b/libavcodec/vorbisenc.c @@ -740,8 +740,10 @@ static int put_main_header(vorbis_enc_context *venc, uint8_t **out) len = hlens[0] + hlens[1] + hlens[2]; p = *out = av_mallocz(64 + len + len/255); - if (!p) + if (!p) { + av_freep(&buffer); return AVERROR(ENOMEM); + } *p++ = 2; p += av_xiphlacing(p, hlens[0]); -- 2.50.0.108.g6ae0c543ae _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".