From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B0E174FAB6 for ; Wed, 25 Jun 2025 20:00:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2E06868D78F; Wed, 25 Jun 2025 22:59:37 +0300 (EEST) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0EFD568D7BF for ; Wed, 25 Jun 2025 22:59:25 +0300 (EEST) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45363645a8eso1612225e9.1 for ; Wed, 25 Jun 2025 12:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750881564; x=1751486364; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UGub4tahiaFw7RVWW1BWqHMCeus5aMTtAUPUe+YtkPA=; b=RMrngiPMB3Rl2zxN3O9cL7X0UpQ4OjBd5/tORDo2ZWWmwXCR7ym7dMIpZviyL8rlX6 aETQqc1ZQ+WyvXmEWV5RhaozkUsv5OkpDz1Fjv+vAdDZ5Zhqu32MkRwTTrpw1Eq0q73O gv/+UAMmGMS9yAZU6RUO0L8aPU6OaRDUkb+2t6SykG1BKzbOsH1MDSU1f8vTWl+pj7f/ 1piKn0mm37e/EICdClqthR7XOCIvAXnWKgH5CIIHotFN1ffeEbnp6s24rLPiEWxqKngI mSfnlGZx707Rppe7jEnD5NuFBWIwksoiqUU7NtaVpd7ZdUkKORY7zxiPFrsIPzBGAmug FBhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750881564; x=1751486364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UGub4tahiaFw7RVWW1BWqHMCeus5aMTtAUPUe+YtkPA=; b=wFmVzP0d49+8rN6mImnPFxMQPgDBrpVrBEHxarbdV3I3Rrf0xQJgPpBxB+zGiXI0FS umr6+ZPc0pL+tkGklU+W4+fp+WZM6KXtmXJnCkp41FissULkEtiZVtKcp8d9nsaKcnoI Byz6P54jvv4Kuyy1tEKVZgbLuspYRcoc1au8uGeLZ+UAhX9pDTI5w6eC2ti18C5DSJgV qAX7kQBFdx8q56k82j9Ja49YJndlbLq4PP4Ha6h0sm4moD1O8bvVAIIcGhLZVe3tvzKp Zsv3HT0kCk3zcDzSbGyx/qVEawarIvAmQBduO7DRI9zLUk1mhyrpABPfOsLiteqqFjgd leBw== X-Gm-Message-State: AOJu0YwJeBvaEkXHROauIUBWaWwSO7bjWaXgOtdSpfc81QDMbT8JQ7a5 TQSPmt+eFM0P6I1laakdwqlCf36JBEJqPkKp2/Iy/Ejz0jtzbzTW7WcOm07xeA== X-Gm-Gg: ASbGncsFiTf81xwCjeGFpcMuk8Bi3uZiAcTp3OnW28DIPXJ4QMu9RT1VBfc9CxO1e3w YRxY2k3Uhbay8hLrJ5ueYpGkGoplWSz4e8qLw0y9yRV0IjYsffWYmIfDanHxlVZdn0T3k+Wti57 KClFjMxtOYSvXGrI3sYHiYJhizNLlfjzVGXHYJRDwXkkm/RssS5RzPuL+ESxOrVKSCzY2aAdKbd /f8cOFU2bk3PwfdxmNEg741+o2rxxcp2Pxv4D+akzmIFz5UFtD53kcDq4ngxk4bqEXbG6Jgo+8K FeGe78VGPVAVYcbKtQvv3bdQyOJ1pkipDPjSvcn+9bPRs39CSzYsW6W9jAIiPJ6zvLRUceuwPkg dYpwg5HWabpHHKrHVo/Z2K7UZW4L40o9e9CweOXAHON6uKf89oc8yVOTz22C48qxKQpt1THMiKG Km+gQO X-Google-Smtp-Source: AGHT+IFtOK0au/8zOHqlvTdmSRACK3i6RM+g7xZ/WOerLA8fsBc6Yf175A/akd2qC4JxnD/s25xzIA== X-Received: by 2002:a05:600c:474a:b0:453:697:6f30 with SMTP id 5b1f17b1804b1-45381b07d29mr40153545e9.32.1750881564131; Wed, 25 Jun 2025 12:59:24 -0700 (PDT) Received: from ArmedBeast.fritz.box (p2003010237004500c9a67543cc7ba10e.dip0.t-ipconnect.de. [2003:102:3700:4500:c9a6:7543:cc7b:a10e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e810977esm5359288f8f.83.2025.06.25.12.59.23 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 25 Jun 2025 12:59:23 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Wed, 25 Jun 2025 21:59:14 +0200 Message-Id: <20250625195916.20276-6-epirat07@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250625195916.20276-1-epirat07@gmail.com> References: <20250625195916.20276-1-epirat07@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 6/8] avformat/tls_openssl: remove unnecessary checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Calling av_free with NULL is a no-op so this check is not needed. --- libavformat/tls_openssl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 86e57ab389..8074251d9d 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -228,8 +228,8 @@ end: av_bprint_finalize(&key_bp, NULL); BIO_free(cert_b); av_bprint_finalize(&cert_bp, NULL); - if (key_tem) av_free(key_tem); - if (cert_tem) av_free(cert_tem); + av_free(key_tem); + av_free(cert_tem); return ret; } @@ -392,8 +392,8 @@ int ff_ssl_gen_key_cert(char *key_buf, size_t key_sz, char *cert_buf, size_t cer snprintf(key_buf, key_sz, "%s", key_tem); snprintf(cert_buf, cert_sz, "%s", cert_tem); - if (key_tem) av_free(key_tem); - if (cert_tem) av_free(cert_tem); + av_free(key_tem); + av_free(cert_tem); error: return ret; } -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".