Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items()

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items()
Date: Tue, 24 Jun 2025 23:19:06 +0200
Message-ID: <20250624211906.GW29660@pb2> (raw)
In-Reply-To: <05b7f838-3271-4646-a5f6-4cc92a28e799@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]

On Mon, Jun 23, 2025 at 11:43:04AM -0300, James Almer wrote:
> On 6/21/2025 6:15 PM, Michael Niedermayer wrote:
> > Fixes: NULL pointer dereference
> > Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >   libavformat/mov.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index 8a094b1ea0a..6e9e3498fb5 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -10336,7 +10336,7 @@ static int mov_parse_heif_items(AVFormatContext *s)
> >           st->codecpar->height = item->height;
> >           err = sanity_checks(s, sc, item->item_id);
> > -        if (err)
> > +        if (err || !sc->sample_count)
> >               return AVERROR_INVALIDDATA;
> >           sc->sample_sizes[0]  = item->extent_length;
> 
> LGTM

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".