From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1144F4FA62 for ; Tue, 24 Jun 2025 21:07:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D0BA568CF06; Wed, 25 Jun 2025 00:07:29 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 27FB168CB4E for ; Wed, 25 Jun 2025 00:07:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 732AC4440A for ; Tue, 24 Jun 2025 21:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750799242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0vYA7cVyuQHBuQRlCJ3faY8geBk6lEy0gAvOTysfVNw=; b=agDAJpnwmiJJsohVzpTzCfHP0AErNz4Mafl4ip3CLzDNdaYVdeSDkrnvsbQjk3tzsGQLxg 8AAYIr8Ph+JaaqqxYUShfYv7uH+nhY8fAK/qWaesF5w3+ceA2xm3AixcbVzMYjMD1JCie1 VKKyULXYmi1XvsfdVrskqeykK3DPeDDE8J16QwiECrccggwc6ORVVkqlsycSHhU8z3RT7C TM/7jtOaDS74xTdJE0s+euFTXD0YgLSvqnD0bXoYlasFRBOozJGz9c6cn+y3SBP0/Ohp69 JPVLMSXixW29xAi/jGtR0RTnWkOKdtcA/iq4xAyo+O86nktlYDAM8vlsxuP59g== Date: Tue, 24 Jun 2025 23:07:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250624210721.GV29660@pb2> References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> <20250617141416.950239-3-502024330056@smail.nju.edu.cn> <20250623115530.GD29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvtdelfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepleekgefgffeiudefjeeuffejudehtddtudeltdehveevvedtieeulefhtdeutdeknecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1230555916022885828==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1230555916022885828== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Sr4lmuivAF0gz0TQ" Content-Disposition: inline --Sr4lmuivAF0gz0TQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Mon, Jun 23, 2025 at 08:48:05PM +0800, ld y wrote: > Michael Niedermayer writes=EF=BC=9A >=20 > > does the other return in config_output() not need this free too? > > >=20 > I believe all the other return behind fir_to_phase() has called > av_free(h[longer]) > already. I would love to add this message to my next patch series. doesnt the failure path here need the free too ? int ret =3D fir_to_phase(s, &h[longer], &n, &post_peak, s->phase); if (ret < 0) return ret; thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Homeopathy is like voting while filling the ballot out with transparent ink. Sometimes the outcome one wanted occurs. Rarely its worse than filling out a ballot properly. --Sr4lmuivAF0gz0TQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFsTiQAKCRBhHseHBAsP q4zDAJ0QuSHtmmLAVFJFKuc6e4UOq8j0iACfTzGn+QVsRxO9fQyoLxhPCJwlLbo= =/pTc -----END PGP SIGNATURE----- --Sr4lmuivAF0gz0TQ-- --===============1230555916022885828== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1230555916022885828==--