Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input()

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input()
Date: Tue, 24 Jun 2025 23:07:21 +0200
Message-ID: <20250624210721.GV29660@pb2> (raw)
In-Reply-To: <CAHiyziP1WQk8+MRCU=cKAQrV6d+Ff09KUoBERQ+wgF9irnj8GQ@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

Hi

On Mon, Jun 23, 2025 at 08:48:05PM +0800, ld y wrote:
> Michael Niedermayer <michael@niedermayer.cc> writes：
> 
> > does the other return in config_output() not need this free too?
> >
> 
> I believe all the other return behind fir_to_phase() has called
> av_free(h[longer])
> already. I would love to add this message to my next patch series.

doesnt the failure path here need the free too ?
        int ret = fir_to_phase(s, &h[longer], &n, &post_peak, s->phase);
        if (ret < 0)
            return ret;

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Homeopathy is like voting while filling the ballot out with transparent ink.
Sometimes the outcome one wanted occurs. Rarely its worse than filling out
a ballot properly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".