From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DEEEC4FA27 for ; Tue, 24 Jun 2025 20:57:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 12EE168CDF6; Tue, 24 Jun 2025 23:57:37 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9408E68C5C3 for ; Tue, 24 Jun 2025 23:57:30 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DB42144537 for ; Tue, 24 Jun 2025 20:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750798650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4R9prpPCBwLkg/VDzV52xQDZAUoHo7eF7TlHJbVIlkI=; b=gJTUg/Y2CNXU7EYg4QZvW9UMM//y2YxGTHp7ed7Z491lEfTKX/P8YyLQTKP9QmkQbBT335 Kb68BtCQlRtJQBY0KeUGuKWPGe8RLivJ4mlPIB5xcB9UzkZ7PEmWj14v371gXb5rKuxAr5 /ONPW/GLNa0qp7PkJykexbGbhw4N+SUOjJa/izfsPSsp/BXeDhFAacvRVXfgdHTd8XFnGM zJtjX0Lr8nv9/orkfcE4lUj1Z9BZ2XIppTfvkMOG8d7u53qeewRycVptzriDlu5ASXr3QP D9eE6wBSj3DTDAzpiv1IpOIvROsajv5uv9CYXE/ToHWoQafxkfNDaqAJNLSzrQ== Date: Tue, 24 Jun 2025 22:57:29 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250624205729.GU29660@pb2> References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> <20250617141416.950239-5-502024330056@smail.nju.edu.cn> <20250623120924.GE29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvtdeludcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4430025937694564920==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4430025937694564920== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IGW/D/u/eKrFjpEO" Content-Disposition: inline --IGW/D/u/eKrFjpEO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 23, 2025 at 08:54:24PM +0800, ld y wrote: > Michael Niedermayer writes: >=20 > > this can be factored like: > > > > like > > + ret =3D 0; > > fail: > > + for (i =3D 0; i < s->nb_streams; i++) > > + if (contexts[i]) > > + av_free(contexts[i]->url); > > av_free(contexts); > > + if (ret < 0) > > sap_write_close(s); > > >=20 > Yeah this looks much better. I will use it in my v2 patch. >=20 > One more question, would it be ok to rename fail label to end label. > I'm not sure if it's worth the change, though. ok in a seperate patch thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope --IGW/D/u/eKrFjpEO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFsRMgAKCRBhHseHBAsP q/J1AJ0XsUGNBw3L+0tO1K+6lTNCl3zk8ACeILowfLP8EXNI6goTtXaZhtYUNh0= =tZIR -----END PGP SIGNATURE----- --IGW/D/u/eKrFjpEO-- --===============4430025937694564920== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4430025937694564920==--