From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header()
Date: Tue, 24 Jun 2025 22:57:29 +0200
Message-ID: <20250624205729.GU29660@pb2> (raw)
In-Reply-To: <CAHiyziM5g=aC4qpk0xSD3EvY-LPZwy-7Gv1simUms+Ock1e7GA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 798 bytes --]
On Mon, Jun 23, 2025 at 08:54:24PM +0800, ld y wrote:
> Michael Niedermayer <michael@niedermayer.cc> writes:
>
> > this can be factored like:
> >
> > like
> > + ret = 0;
> > fail:
> > + for (i = 0; i < s->nb_streams; i++)
> > + if (contexts[i])
> > + av_free(contexts[i]->url);
> > av_free(contexts);
> > + if (ret < 0)
> > sap_write_close(s);
> >
>
> Yeah this looks much better. I will use it in my v2 patch.
>
> One more question, would it be ok to rename fail label to end label.
> I'm not sure if it's worth the change, though.
ok in a seperate patch
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-06-24 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 14:14 [FFmpeg-devel] [PATCH 0/4] fix multiple memory leaks Lidong Yan
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 1/4] libavformat/rtmpproto: fix rmtp packet leak in gen_connect() Lidong Yan
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() Lidong Yan
2025-06-23 11:55 ` Michael Niedermayer
2025-06-23 12:48 ` ld y
2025-06-24 21:07 ` Michael Niedermayer
2025-06-25 1:43 ` ld y
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: fix leak in sbg_read_header() Lidong Yan
2025-06-17 14:23 ` Nicolas George
2025-06-17 14:28 ` James Almer
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header() Lidong Yan
2025-06-23 12:09 ` Michael Niedermayer
2025-06-23 12:54 ` ld y
2025-06-24 20:57 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624205729.GU29660@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git