From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 54F904F8D5 for ; Mon, 23 Jun 2025 14:34:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2577A68DDB7; Mon, 23 Jun 2025 17:34:06 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8E45F68DD84 for ; Mon, 23 Jun 2025 17:33:58 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E6257443C5 for ; Mon, 23 Jun 2025 14:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750689238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BCh817acMLay7R481TCFsA6+3IJbrQlYUonVuob17yI=; b=AKas+c4WdNgzImkT0sPkFbnIUgQeyaGnh2oZ1JJZVCJ4V6ueK+ViF25BPonNEbpBw0GMl2 J/iIhwnUWA1RR/j5qJ5dzhC2+K1FK5zvuT5EzLc5svxVLOnlqS9yWMubDNbp21gqGsTw5G iX8Q54vvoYMB3l72wVV8dB97tvq86jdC14HhLPVLgATq2XWaGRBgRj/jjH4jAPSOuLIV5u om3jR08cokkQr9UUrihfaAsoJG7AKics/E4C7q2OYRAXfxQOeJKe2HfXQl4taF4ok8Wnvo IZvF0XXQtT1v9xYX5tTrnH7c7/9gyTTo8FDCGO3cjEXQ8usHalNgJ6bAUKKojQ== Date: Mon, 23 Jun 2025 16:33:57 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250623143357.GO29660@pb2> References: <20250621211521.895204-1-michael@niedermayer.cc> <20250621211521.895204-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddujedvjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnheptefggedvffeiueffvefhiedtgfefjedukeefgeetgeevgeejgeekvdevjeelveeknecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0591012993656325277==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0591012993656325277== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YTScVnB7azXOs8th" Content-Disposition: inline --YTScVnB7azXOs8th Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 22, 2025 at 02:40:23PM +1000, Peter Ross wrote: > On Sat, Jun 21, 2025 at 11:15:20PM +0200, Michael Niedermayer wrote: > > Fixes: division by 0 > > Fixes: 418396712/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-6= 104388018176000 > > Fixes: 418478219/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4= 569544410857472 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/iff.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/iff.c b/libavformat/iff.c > > index 9402be48c98..4ff10beb38a 100644 > > --- a/libavformat/iff.c > > +++ b/libavformat/iff.c > > @@ -284,7 +284,7 @@ static int parse_dsd_prop(AVFormatContext *s, AVStr= eam *st, uint64_t eof) > > return AVERROR_INVALIDDATA; > > st->codecpar->ch_layout.order =3D AV_CHANNEL_ORDER_U= NSPEC; > > st->codecpar->ch_layout.nb_channels =3D avio_rb16(pb); > > - if (size < 2 + st->codecpar->ch_layout.nb_channels * 4) > > + if (size < 2 + st->codecpar->ch_layout.nb_channels * 4 || = !st->codecpar->ch_layout.nb_channels) > > return AVERROR_INVALIDDATA; > > if (st->codecpar->ch_layout.nb_channels > FF_ARRAY_ELEMS(d= sd_layout)) { > > avpriv_request_sample(s, "channel layout"); >=20 > please apply will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact --YTScVnB7azXOs8th Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFll1QAKCRBhHseHBAsP q2cXAJ0UAR4/mExtkLgtjCfJn9/26QvdUACgkiALDwBaJKOd5XEkAWLoENa2Tfk= =UujU -----END PGP SIGNATURE----- --YTScVnB7azXOs8th-- --===============0591012993656325277== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0591012993656325277==--