Re: [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL
Date: Mon, 23 Jun 2025 16:33:57 +0200
Message-ID: <20250623143357.GO29660@pb2> (raw)
In-Reply-To: <aFeJN1vHZBNJBJxW@d68bcc34515074c2bef9ef642706ab6e>

[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]

On Sun, Jun 22, 2025 at 02:40:23PM +1000, Peter Ross wrote:
> On Sat, Jun 21, 2025 at 11:15:20PM +0200, Michael Niedermayer wrote:
> > Fixes: division by 0
> > Fixes: 418396712/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-6104388018176000
> > Fixes: 418478219/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4569544410857472
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/iff.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/iff.c b/libavformat/iff.c
> > index 9402be48c98..4ff10beb38a 100644
> > --- a/libavformat/iff.c
> > +++ b/libavformat/iff.c
> > @@ -284,7 +284,7 @@ static int parse_dsd_prop(AVFormatContext *s, AVStream *st, uint64_t eof)
> >                  return AVERROR_INVALIDDATA;
> >              st->codecpar->ch_layout.order       = AV_CHANNEL_ORDER_UNSPEC;
> >              st->codecpar->ch_layout.nb_channels = avio_rb16(pb);
> > -            if (size < 2 + st->codecpar->ch_layout.nb_channels * 4)
> > +            if (size < 2 + st->codecpar->ch_layout.nb_channels * 4 || !st->codecpar->ch_layout.nb_channels)
> >                  return AVERROR_INVALIDDATA;
> >              if (st->codecpar->ch_layout.nb_channels > FF_ARRAY_ELEMS(dsd_layout)) {
> >                  avpriv_request_sample(s, "channel layout");
> 
> please apply

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".