From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1498E4F7D1 for ; Mon, 23 Jun 2025 12:33:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BD0F868E0A4; Mon, 23 Jun 2025 15:33:19 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0C8B468D937 for ; Mon, 23 Jun 2025 15:33:14 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5415B44251 for ; Mon, 23 Jun 2025 12:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750681993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1BdIfrBuOgz6i9fOjmf5Bc9jNS/b8WMIiDSJt7qfUTo=; b=CAjgGDT5r7Lyyhltgn/vWSzpn7KLw/yfe3gmcbDqhCr4vve1gOnn27OnWdnrIm4cdYjn1B 5k/DGGg/jwlB4gOoAQ7i8XzXWYuU7lgMJ7DYi/mreUXb2JvyGxnWPN1XE2XDhoCgbCSugH +c1NojoYHd/4lJyAreWAor2PiGIeUyXNk0MkKOqo+hYLCwBZuYYd3cJE6vwAlh0Cw6eaEf vQc0WHqPrWmq2xGUaCcYMy9YOsYEGxmrb0oJO9A1tT9W8CRNgVTt261cVMMVVfHZBPoNt7 T/8rAw9So63VaY09OgBybskaReEu3lE8KSXNFA/Axtzv4SLaxho6pcCw2+F50g== Date: Mon, 23 Jun 2025 14:33:12 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250623123312.GH29660@pb2> References: <20250617203216.4117940-1-michael@niedermayer.cc> <20250618004421.GM29660@pb2> MIME-Version: 1.0 In-Reply-To: <20250618004421.GM29660@pb2> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddujedtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0972191579848873775==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0972191579848873775== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="99YDrNWRObzS7Pej" Content-Disposition: inline --99YDrNWRObzS7Pej Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2025 at 02:44:21AM +0200, Michael Niedermayer wrote: > On Wed, Jun 18, 2025 at 09:14:40AM +1000, Peter Ross wrote: > > On Tue, Jun 17, 2025 at 10:32:16PM +0200, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/osq.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > >=20 > > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c > > > index 025be667a35..0de9af5f623 100644 > > > --- a/libavcodec/osq.c > > > +++ b/libavcodec/osq.c > > > @@ -212,6 +212,8 @@ static int osq_channel_parameters(AVCodecContext = *avctx, int ch) > > > cb->residue_parameter =3D get_urice(gb, 4); > > > if (!cb->residue_parameter || cb->residue_parameter >=3D 31) > > > return AVERROR_INVALIDDATA; > > > + if (cb->coding_mode =3D=3D 2) > > > + avpriv_request_sample(avctx, "coding mode 2\n"); > >=20 > > nit: there is no need for newline character with avpriv_request_sample() >=20 > corrected locally will apply [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --99YDrNWRObzS7Pej Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFlJiAAKCRBhHseHBAsP qxW/AJ46UvUBiw6YdZhmVGa9Qfwt4+S4ZgCfQ0ygXXVcrtY3wxXQ9IZgPRUECm8= =PvHK -----END PGP SIGNATURE----- --99YDrNWRObzS7Pej-- --===============0972191579848873775== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0972191579848873775==--