[FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

[FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

[Michael Niedermayer]

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/osq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/osq.c b/libavcodec/osq.c
index 025be667a35..0de9af5f623 100644
--- a/libavcodec/osq.c
+++ b/libavcodec/osq.c
@@ -212,6 +212,8 @@ static int osq_channel_parameters(AVCodecContext *avctx, int ch)
         cb->residue_parameter = get_urice(gb, 4);
         if (!cb->residue_parameter || cb->residue_parameter >= 31)
             return AVERROR_INVALIDDATA;
+        if (cb->coding_mode == 2)
+            avpriv_request_sample(avctx, "coding mode 2\n");
     } else if (cb->coding_mode == 3) {
         cb->residue_bits = get_urice(gb, 4);
         if (!cb->residue_bits || cb->residue_bits >= 31)
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 854 bytes --]

On Tue, Jun 17, 2025 at 10:32:16PM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/osq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/osq.c b/libavcodec/osq.c
> index 025be667a35..0de9af5f623 100644
> --- a/libavcodec/osq.c
> +++ b/libavcodec/osq.c
> @@ -212,6 +212,8 @@ static int osq_channel_parameters(AVCodecContext *avctx, int ch)
>          cb->residue_parameter = get_urice(gb, 4);
>          if (!cb->residue_parameter || cb->residue_parameter >= 31)
>              return AVERROR_INVALIDDATA;
> +        if (cb->coding_mode == 2)
> +            avpriv_request_sample(avctx, "coding mode 2\n");

nit: there is no need for newline character with avpriv_request_sample()

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1211 bytes --]

On Wed, Jun 18, 2025 at 09:14:40AM +1000, Peter Ross wrote:
> On Tue, Jun 17, 2025 at 10:32:16PM +0200, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/osq.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/osq.c b/libavcodec/osq.c
> > index 025be667a35..0de9af5f623 100644
> > --- a/libavcodec/osq.c
> > +++ b/libavcodec/osq.c
> > @@ -212,6 +212,8 @@ static int osq_channel_parameters(AVCodecContext *avctx, int ch)
> >          cb->residue_parameter = get_urice(gb, 4);
> >          if (!cb->residue_parameter || cb->residue_parameter >= 31)
> >              return AVERROR_INVALIDDATA;
> > +        if (cb->coding_mode == 2)
> > +            avpriv_request_sample(avctx, "coding mode 2\n");
> 
> nit: there is no need for newline character with avpriv_request_sample()

corrected locally

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]

On Wed, Jun 18, 2025 at 02:44:21AM +0200, Michael Niedermayer wrote:
> On Wed, Jun 18, 2025 at 09:14:40AM +1000, Peter Ross wrote:
> > On Tue, Jun 17, 2025 at 10:32:16PM +0200, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > >  libavcodec/osq.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c
> > > index 025be667a35..0de9af5f623 100644
> > > --- a/libavcodec/osq.c
> > > +++ b/libavcodec/osq.c
> > > @@ -212,6 +212,8 @@ static int osq_channel_parameters(AVCodecContext *avctx, int ch)
> > >          cb->residue_parameter = get_urice(gb, 4);
> > >          if (!cb->residue_parameter || cb->residue_parameter >= 31)
> > >              return AVERROR_INVALIDDATA;
> > > +        if (cb->coding_mode == 2)
> > > +            avpriv_request_sample(avctx, "coding mode 2\n");
> > 
> > nit: there is no need for newline character with avpriv_request_sample()
> 
> corrected locally

will apply

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".