From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D25644BEBB for ; Sat, 21 Jun 2025 22:00:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4240968CFFE; Sun, 22 Jun 2025 00:59:56 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4363068C3AD for ; Sun, 22 Jun 2025 00:59:49 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7EDC8433CF for ; Sat, 21 Jun 2025 21:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750543188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=72ZhZfMPb0uuxij8WneG+D/vlVY5zFClFkPfGM54esg=; b=KIHPKQ1Wn4IXDXiHrtO6v9jlfEgaKc7X7tgKucrIF3d4vLcIJkMGHHvwLmepFBfAdh6c/L WN9K894+Rd/qN4zvs5efhjdp4vT+VYuTQbFTzi/Qfz66rQj4mIOEKUNQjA10ZxrXxb5sPO rIlp+FVY8z2QsuAftRRTF8DZRyYcplV+H/4DLCg41E01BhkYXHGaQ/geRM+Vh43nWe/Gmq k8vVCvG2gJt3PexuEkfJH6GD+JrdvghghjTJekARIPvJbD3oDdvVMT7JTwjc4TXH5zpfqO qumCa45sqoqU3bWONMzmPDqVeU5+vRqqqDPFgqAEb/TfG8umNHYJYFj4cmWjww== Date: Sat, 21 Jun 2025 23:59:47 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250621215947.GY29660@pb2> References: <20250604165852.75087-1-romain.beauxis@gmail.com> <20250614225713.GP29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgdduvdegvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepudetvdfhudeuudegudefgfehhfevvdfggfffkefhvdfgvdetffdtjeekheetfeehnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8897459331728615154==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8897459331728615154== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="psbA6nEa0eQY0Oz7" Content-Disposition: inline --psbA6nEa0eQY0Oz7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote: > Le dim. 15 juin 2025 =E0 00:57, Michael Niedermayer > a =E9crit : > > > > On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote: > > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a fl= at > > > memory storage for the extradata. > > > > > > PR review comments addressed: > > > * Use flat memory bytestream > > > * Re-use existing xiph extradata layout > > > > > > --- > > > > > libavcodec/vorbisdec.c | 42 ++++++++--- > > > libavformat/oggparsevorbis.c | 83 ++++++++++++++++++++= +- > > > > patches that change both libraries at the same time are suspect > > > > if one depends on changes in the other it needs > > minor API version bump and seperate patches so extension of > > API and use of it are properly tracked and testable >=20 > If I remember well, according to Andreas Rheinhardt there's no need > for an API bump here since the patch is re-using existing extradata > bitstream structures. If there is really no API extension then the micro versions should be bumped so a user knows if the specific version he uses has teh fix. Also it may be usefull in bugreports about ogg to know if its prior or after this change thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --psbA6nEa0eQY0Oz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFcrTwAKCRBhHseHBAsP q/n8AJ9cgACOVhTKuLp8R9Ym9gEavFSlqwCfen/c49OrE6PGS2g30BQDqy6hAuA= =RGOE -----END PGP SIGNATURE----- --psbA6nEa0eQY0Oz7-- --===============8897459331728615154== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8897459331728615154==--