Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Sat, 21 Jun 2025 23:59:47 +0200
Message-ID: <20250621215947.GY29660@pb2> (raw)
In-Reply-To: <CABWZ6OROgtAcqsoY1Ykey=Nj4O9qkw0STwQGD1-ekOykOKiyAg@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1677 bytes --]

On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote:
> Le dim. 15 juin 2025 à 00:57, Michael Niedermayer
> <michael@niedermayer.cc> a écrit :
> >
> > On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote:
> > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a flat
> > > memory storage for the extradata.
> > >
> > > PR review comments addressed:
> > > * Use flat memory bytestream
> > > * Re-use existing xiph extradata layout
> > >
> > > ---
> >
> > >  libavcodec/vorbisdec.c                     | 42 ++++++++---
> > >  libavformat/oggparsevorbis.c               | 83 +++++++++++++++++++++-
> >
> > patches that change both libraries at the same time are suspect
> >
> > if one depends on changes in the other it needs
> > minor API version bump and seperate patches so extension of
> > API and use of it are properly tracked and testable
> 
> If I remember well, according to Andreas Rheinhardt there's no need
> for an API bump here since the patch is re-using existing extradata
> bitstream structures.

If there is really no API extension then the micro versions should be bumped
so a user knows if the specific version he uses has teh fix.
Also it may be usefull in bugreports about ogg to know if its prior or
after this change

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".