From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 896304B956 for ; Fri, 20 Jun 2025 14:28:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D686668DCE3; Fri, 20 Jun 2025 17:28:31 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 59FCB68CD4E for ; Fri, 20 Jun 2025 17:28:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B6E3B1F433 for ; Fri, 20 Jun 2025 14:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750429704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QfS8fLDLyiA06bd7205bCJeaK1pUxDc17YMwzoEt6Nk=; b=dOY7zngmT1ivk9kfIGpKELXlrByIx36JfcR0UrpUPlCjNYPQlDCg+WnWoi2KkR0mINSau+ YmKoqVnV0diHqaTwiA66IWafqz2Cw9j5N0R4h7xmSay78Q1m2W82lp3Y9GOBL71orvio1h 3Tf6TBWXviI2snpQADw5jwDdszoNuCTWESBkQ6CxNSEWqrVT13JxeBL7NFG1mVF/kFOvAM JjaXPZ4tG9x9Mdh6Y8gj4Yg7eIV6f6U5jKDeGXc6aOcVsTfQYqGQ44FYUVYV/E7hEC3ZrM krsjDli+E3/C/UOgXIycMHbJ0EprbF8uX6I1yiYKqh5RutuNu4fGQMY1K7INpg== Date: Fri, 20 Jun 2025 16:28:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250620142823.GT29660@pb2> References: <20250620003255.295598-1-michael@niedermayer.cc> <20250620003255.295598-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgdekieegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeetgfegvdffieeuffevhfeitdfgfeejudekfeegteegveegjeegkedvveejleevkeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/8] avcodec/hcadec: Check sample_rate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6484710657225912090==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6484710657225912090== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ztCbAr/xHTLhel65" Content-Disposition: inline --ztCbAr/xHTLhel65 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andreas On Fri, Jun 20, 2025 at 10:45:46AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: AVERROR_BUG return > > Fixes: 413997604/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_= fuzzer-5188382613635072 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/hcadec.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c > > index 7780372cf3f..161044bfbcc 100644 > > --- a/libavcodec/hcadec.c > > +++ b/libavcodec/hcadec.c > > @@ -179,6 +179,9 @@ static void ath_init1(uint8_t *ath, int sample_rate) > > =20 > > static int ath_init(uint8_t *ath, int type, int sample_rate) > > { > > + if (sample_rate <=3D 0) > > + return AVERROR_INVALIDDATA; > > + > > switch (type) { > > case 0: > > /* nothing to do */ >=20 > The sample rate used here comes from avctx->sample_rate, > so why do you > want to check this here instead of checking it generically for all audio > decoders without AV_CODEC_CAP_CHANNEL_CONF I have not considered this alternative. Your patch is better thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --ztCbAr/xHTLhel65 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFVwBAAKCRBhHseHBAsP qxgbAJsEZlAn7ZtZ0SBVbmdiYqnTvGT8RACbB3nDgeI7N56WAplvd/EHqmcZQuM= =iEzw -----END PGP SIGNATURE----- --ztCbAr/xHTLhel65-- --===============6484710657225912090== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6484710657225912090==--