From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7CEA54F5A6 for ; Tue, 17 Jun 2025 23:56:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8496868DAEC; Wed, 18 Jun 2025 02:56:35 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 592BD68C6C8 for ; Wed, 18 Jun 2025 02:56:28 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 856F541C06 for ; Tue, 17 Jun 2025 23:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750204587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d9rre2ho3Ds4eE1cOiJT06dIeSmA5TbqCO8jZoUyiKk=; b=bpJzt5yFZCiZ3eIX4NSmZRosJtpxqmDidzrYamNV96Wba97G3cXQRr4qvzyOR2+GTEHSyp 0XJIBg+ZdRWANJEkU8qNePOqsbjPbADpVUpjHDKYViFWAhhB03GgEZvjYADLmRgL2thGRl h8eAB0cYLU/ruhpZzHRZFnFjEz1TfGI8xEylEt8gRZleNVaz02UFbmCs9xuwfoID6D4m07 2sfxKyt1CUQh4+N1tJYNLmeRE6hnkY5pOy1gy+KiRmGHyHvPrEb7utLlunwIiYCeJiuffF Gn7qLTv15I8J4gzajZR+fLqaBTCbCakicnluoF5ieCWzIUI2x1y+yoogusLrUQ== Date: Wed, 18 Jun 2025 01:56:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250617235625.GL29660@pb2> References: <2dc54cad-932f-4c30-9f9d-0a943e0a7be3@regaud-chapuy.fr> <639a031a-06c7-4855-8d97-de61626ba194@regaud-chapuy.fr> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgdduheehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeehkefhleeigfevleeijedvieelfeehuefghfejtdfggeeigeekuefhleelfffgieenucffohhmrghinhepvdeigedrihhtnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/h264: fixed qp table attach for h264 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4309457158954380655==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4309457158954380655== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tCNAu/+glv6ION1M" Content-Disposition: inline --tCNAu/+glv6ION1M Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2025 at 09:29:01AM +0200, Timothee wrote: > Context from the first version : >=20 > > Here is a patch where I fixed the attach of per-macroblock qp tables for > > H.264. It was implemented for MPEG2 so I have only extended it. > >=20 > > I tested the functionality with the codecview filter using the following > > command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=3Dqp= =3D1 > > output.mp4` >=20 > Andreas : > > 1. Commits should be small atomic units; changes to different libraries > > in the same commit are almost always not of this type. > > 2. Both ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() already > > set qscale_table on their own (on success), so that all the changes to > > h264_slice.c seem completely redundant. > >=20 > > - Andreas >=20 > Here is a new version of the patch without the redundant lines. >=20 > Thanks, >=20 > Timoth=E9e > qp_table.c | 3 ++- > qp_table.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > f5478a074261026e13cd6ec745b80aee4a0720b5 0001-avcodec-h264-fixed-qp-tabl= e-attach-for-h264.patch > From 422e8dbdc3d79b24c6ccb11b7f384fc08406ee74 Mon Sep 17 00:00:00 2001 > From: Timothee > Date: Fri, 13 Jun 2025 14:21:28 +0200 > Subject: [PATCH] avcodec/h264: fixed qp table attach for h264 >=20 > Signed-off-by: Timothee > --- > libavcodec/h264_slice.c | 16 ++++++++++++---- > libavfilter/qp_table.c | 3 ++- > libavfilter/qp_table.h | 1 + > 3 files changed, 15 insertions(+), 5 deletions(-) >=20 > diff --git a/libavfilter/qp_table.c b/libavfilter/qp_table.c > index 8137dc019f..a99b99e77a 100644 > --- a/libavfilter/qp_table.c > +++ b/libavfilter/qp_table.c > @@ -40,7 +40,8 @@ int ff_qp_table_extract(AVFrame *frame, int8_t **table,= int *table_w, int *table > if (!sd) > return 0; > par =3D (AVVideoEncParams*)sd->data; > - if (par->type !=3D AV_VIDEO_ENC_PARAMS_MPEG2 || > + if ((par->type !=3D AV_VIDEO_ENC_PARAMS_MPEG2 > + && par->type !=3D AV_VIDEO_ENC_PARAMS_H264) || > (par->nb_blocks !=3D 0 && par->nb_blocks !=3D nb_mb)) > return AVERROR(ENOSYS); The commit message should be a bit more verbose why these are unequal, and why teh later copy of nb_mb is correct If its not always correct, that should at least be documented > =20 > diff --git a/libavfilter/qp_table.h b/libavfilter/qp_table.h > index 4407bacb0e..c1a80d1830 100644 > --- a/libavfilter/qp_table.h > +++ b/libavfilter/qp_table.h > @@ -40,6 +40,7 @@ static inline int ff_norm_qscale(int qscale, enum AVVid= eoEncParamsType type) > { > switch (type) { > case AV_VIDEO_ENC_PARAMS_MPEG2: return qscale >> 1; > + case AV_VIDEO_ENC_PARAMS_H264: return qscale; > } > return qscale; This does nothing, it returns qscale already thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --tCNAu/+glv6ION1M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFIApgAKCRBhHseHBAsP q0zqAJ4vs/trO6yjtiRv/aFHrUNXO2X19ACfaNTYeP8N0Pnyammih3CtAi6KcsQ= =Xvpj -----END PGP SIGNATURE----- --tCNAu/+glv6ION1M-- --===============4309457158954380655== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4309457158954380655==--