From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5DF374F583 for ; Tue, 17 Jun 2025 20:46:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8642D68D10D; Tue, 17 Jun 2025 23:46:15 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BEDB168C319 for ; Tue, 17 Jun 2025 23:46:08 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 10D4044331 for ; Tue, 17 Jun 2025 20:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750193168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s91P/R8ZL4sRSqG7BjlX3L5YBflB5NNcNEkxY9xkxvs=; b=FFyhGxn+QVbaFBU5aWFG50qrUKTstXVxqRAzMuBKAOZhCdOwRQXQxtekptwyqsOyI01qDv 8eY1tkaG9/dc+LHJzNDCgdhy1n6x/DAVCgtnYBjgFlgve562rM1zdKGDY7P7UtMYA9X/yT mx6uW95vWfpQ/tDmjp3oLJgeHHR/8FMGj/b6hBsGcHxhqqchecHuGjDt1ll6wCKuOkacT6 dFyo7vvSPDo0MxpGly1jKq0nKNdF7RRZjx6/KT9dplJrLEW16qtFSZB+2GOiNx4CWvrUQu yysg33/gZdS3Ys2jKjX+io5xbW2wwSHfe+ZrwMcm1FKJ4kKa5crbPTO1QumOeQ== Date: Tue, 17 Jun 2025 22:46:06 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250617204606.GK29660@pb2> References: <20250617143659.26607-1-pkoshevoy@gmail.com> <7822783e-7117-d3ac-51fa-c83a8d9786b8@passwd.hu> MIME-Version: 1.0 In-Reply-To: <7822783e-7117-d3ac-51fa-c83a8d9786b8@passwd.hu> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgdduudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/demux: Add allow_codec_changes option to AVFormatContext (v2) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0708407357623596463==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0708407357623596463== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EH/3JKBrYMkznCzI" Content-Disposition: inline --EH/3JKBrYMkznCzI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2025 at 08:39:05PM +0200, Marton Balint wrote: >=20 >=20 > On Tue, 17 Jun 2025, Pavel Koshevoy wrote: >=20 > > Make runtime AVStream.codecpar codec_id updates optional and disabled > > by default, so that avformat API clients can enable this feature explic= itly > > when they add support for runtime codec changes. > >=20 > > Accordingly, codec_close should not assume that the codec_id cannot cha= nge. > > This fixes 'ffprobe 1_poc.mp4' segfault introduced with > > commit 0021484d05f9b0f032fa319399de6e24eea0c04f. > > --- > > doc/APIchanges | 3 +++ > > doc/formats.texi | 6 ++++++ > > libavformat/avformat.h | 10 ++++++++++ > > libavformat/demux.c | 8 +++++++- > > libavformat/mpegts.c | 4 +++- > > libavformat/options_table.h | 1 + > > libavformat/version.h | 2 +- > > tests/fate/demux.mak | 2 +- > > 8 files changed, 32 insertions(+), 4 deletions(-) > >=20 > > diff --git a/doc/APIchanges b/doc/APIchanges > > index 91710bb27d..29b3389094 100644 > > --- a/doc/APIchanges > > +++ b/doc/APIchanges > > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 202= 5-03-28 > >=20 > > API changes, most recent first: > >=20 > > +2025-06-17 - xxxxxxxxxx - lavf 62.2.100 - avformat.h > > + Add AVFormatContext.allow_codec_changes AVOption. >=20 > Considering that this is a simple boolean option, maybe you should use > AVFormatContext->flags instead, so no new field need to be added, only a = new > flag. as a seperate value it could be extended to somethig like -allow_codec_changes ALL -allow_codec_changes NONE -allow_codec_changes WITHIN_TYPE (no type change like video to audio) but not sure this makes sense or is even reasonable implementation wise anyway i have nothing against making this a flag if people prefer just wanted to provide an example where a flag would be at a disadvantage thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --EH/3JKBrYMkznCzI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFHUCwAKCRBhHseHBAsP q4d6AJ9azikq2BtxvQXrnAOTufnn1L5/agCdG8giaVGhiigaupB6v5k6z++TAt8= =OkcM -----END PGP SIGNATURE----- --EH/3JKBrYMkznCzI-- --===============0708407357623596463== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0708407357623596463==--