From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9938F4F4FD for ; Tue, 17 Jun 2025 14:14:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 33E9668D34E; Tue, 17 Jun 2025 17:14:39 +0300 (EEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2121A68C32D for ; Tue, 17 Jun 2025 17:14:35 +0300 (EEST) Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-74877ac9d42so3600208b3a.1 for ; Tue, 17 Jun 2025 07:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750169674; x=1750774474; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uqECYExPzjiv4098uVfEQ3L/HB0PGnLdWREvRU3MlL0=; b=VwHNaXjaWjlWKL87TXDF80hYNgxei5CsbuWvT0da8W/ti9ngcxWAkkCChsx7zoGWLb ReM9GiLFqOnibKFODcvlPyEInCKCtKF42tCDStPl7FDrj32Aqm87JiWCsrOBqViFNyS5 LGBWZOtjWx53uIthXKn/WJln+9UDecxULZEI5hnzdbkbcj5JkZe4TuTdiZM94hQUONnz JB311q1YU558g0sdpxCOoCt1llY57I+YkJ8c1zFgQfFOd+/5daQdt5SIcWYLrEMuMTV8 /UfmqGMTTQ2EJdXLR4R+qIEnL87Qce5jy6Ve7HrrZu/Rcxcwvlgu1N70OvljNT6wBjnn CbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750169674; x=1750774474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uqECYExPzjiv4098uVfEQ3L/HB0PGnLdWREvRU3MlL0=; b=gKvMSmromG7KSZma3geQE635q5IuOL1YRhSdc+ArXMYYwj1rfazJgfVpyHe60yeUh7 jEBwiUdEJ8kwtr9Bfz3nvdIJ4JS/tq5m93N6rYVYByobScQnssR3ozdOnwqvowVPKr5o B/Uejig9oFNqKrD12/QdMpilgxip4Tuv5il0StTEEDRU6mUfYMl/g31zh3Or9X6TGH0x 74gVmF4W/wOag53yCj9p5+E+3/hOWrQQfJ5a4eSZauV4rqv1qH3j5ff0JQG6FTU/tmtd fqabDZgYznDx9UBvSXkZSXDeBx//FkB3sUtWfwStMw83HJGug0Ui/QlkCf0s2c9vgI+R 4WPw== X-Gm-Message-State: AOJu0YzII6G+hB7DPXWohA25uQZ6tX816eG8n3B3gpCvkd4hAwg1WXwE 86ezW7PKN0bksKHr6pAtoO6KgTfq9Zi+BSr/5gUD0prs6u3PLzk0/vxIk2IIWRQeG2LRGF/b X-Gm-Gg: ASbGncuIxizUr8eia6dqQbdMcWTJmMemoZwPcb4AMy/OecbHiBeH5a/fhlbukZta2r0 2KS29xirhtt+hdZ+9g1uykGOuS6rx2rrcqozGS5NT0WVJkAlQQMDoM8vnw7vi9ak0VpXJ2ZQUeu AJq+GLZ5e9YrORLQgbBNZVNwf33SNqGOKTCGSH8PcpkFrFg8OM7onJosfg5w6VpOLm2weKPwFMP 4by8Sxso3PZjD9sjU8H/ZQswuSrEkNkPI6MJ4k0bHU0b1ZFABzspr5UsNUEx4eG8ULvQgOoqgoh vxIA1IqRWEEWBN55Vn1mauaEH8k9WmPDGyPwoa028l1c/OW+nwjIBGXh1MzIl/HYyBo5 X-Google-Smtp-Source: AGHT+IE4vTAX8MNljFertm/IlZ219pajvVJZ9jK8QvaAY4Hh/0aVQZ/aW5C3z4XweIfKZLvmtpzddA== X-Received: by 2002:a05:6a00:1248:b0:748:68dd:eb8c with SMTP id d2e1a72fcca58-7489d006342mr19763678b3a.23.1750169673874; Tue, 17 Jun 2025 07:14:33 -0700 (PDT) Received: from r760 ([188.253.126.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748900b2e30sm8838413b3a.128.2025.06.17.07.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 07:14:33 -0700 (PDT) From: Lidong Yan X-Google-Original-From: Lidong Yan <502024330056@smail.nju.edu.cn> To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Jun 2025 22:14:15 +0800 Message-ID: <20250617141416.950239-4-502024330056@smail.nju.edu.cn> X-Mailer: git-send-email 2.50.0-rc1 In-Reply-To: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: fix leak in sbg_read_header() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lidong Yan <502024330056@smail.nju.edu.cn> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In sbg_read_header(), if avformat_new_stream() failed, it returns without cleanup, which may cause memory leaks. Replace return statement with goto so that we would first clean up then return. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> --- libavformat/sbgdec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c index bf319be228..4afb51b844 100644 --- a/libavformat/sbgdec.c +++ b/libavformat/sbgdec.c @@ -1434,8 +1434,10 @@ static av_cold int sbg_read_header(AVFormatContext *avf) } st = avformat_new_stream(avf, NULL); - if (!st) - return AVERROR(ENOMEM); + if (!st) { + r = AVERROR(ENOMEM); + goto fail; + } sti = ffstream(st); st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO; st->codecpar->codec_id = AV_CODEC_ID_FFWAVESYNTH; -- 2.50.0-rc1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".