From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C859C4F4DF for ; Tue, 17 Jun 2025 14:15:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0BAA368C3D5; Tue, 17 Jun 2025 17:14:43 +0300 (EEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 99A0468CFDC for ; Tue, 17 Jun 2025 17:14:33 +0300 (EEST) Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-747abb3cd0bso5080782b3a.1 for ; Tue, 17 Jun 2025 07:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750169672; x=1750774472; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z3wBpLb0dalHN0PJxGtGIgflB+Nxll2QTxw8iUrHTX0=; b=bvmy63BHK6FH0jRrMrUjf3qaZoS/PDJzfNsmQwE6OI8wP1lSPHbB8JxN/EM/bQ373O Kqd8o+RkfLJ0kwg7SpiWQlc3T0Il+KWG7OPHEBfOv569GuWeI3/BMKzVq+amm0H5Sqda J9zI5Z2wfOLuf6jUFSIaHpExnT6XJQPaXRmuDPFAxwg/ivQHYb5WF/jTWs1+3yJzi3C0 B3WxifHqPxjCFFM+1/uGng1U0SojkL2vcgFB7sJLUSZ9FlgbtAjjf4NHOuZ4vHnL2ZX9 TAmfFzs8/wSdb2b5+C6bJ9zfbUzW4vROS2zsiGpYQ/QqtFzns4mpfmqtyHoUBj0fzrCf 3dNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750169672; x=1750774472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z3wBpLb0dalHN0PJxGtGIgflB+Nxll2QTxw8iUrHTX0=; b=AfyyfKTY2zxqR/mYZT+pxBDvdXHrmlG9u/rO/8rTQkHtjU8YWfU1OoM7J1ZDlw9Uvf Cez5KSsh7ekoAhvoEzN5z5mMQcTI7jGK+8WH4TxmJBBGIUK26RzmY8WoJaVJvpyRGMvE oFNEUC1CAh4uyqI3xpOOwodoL5/3RXVlQJvRsSKoKncG+YGp4Rr5RyQBfk319ycWjVcy x1Spmrd+zMcQKc4tU9Z8xSwMsAXqQp/a/MI7UBoY6lMM+oZhWRHTpKsOJfskc2Hd5r5n 97QE3N26TXN+f3oTiOrX4kse/d3VZXt/z42/7pSniWrlKo6sHlfpVoVZr9Y0Sa/m+j9z PgwQ== X-Gm-Message-State: AOJu0Yw5XhPVA1OF5mpDPyFSfEpj/rstyKdunS/KNWTPpilT6aX6YnuM 4jhU1TXT3m1fKshyBd7LUplqpkYJNcQLykoIULAfFoipAP7p7jr9eGNLdOaFF+8YIJCnG0wZ X-Gm-Gg: ASbGnctXcP+IcSOyXyRXKf7ExfQggTRoFdCisPaViR5IjMYzjI2WCLWAHgKB1cOlV4y GqLNlrsDu8eixWGJnFamZQxWmcGiD007tKcNl6vstC7QU8MiMDW2ZYnBLeSuDhodLSdfkv8yR8z WOYgXAvVIMMbUU8NC9sx+5L8ABUa9oT/Ohi7OhYBumBvV1lJTsh2LqaiYfjlILyXa1oYXI+TWYE mhWdNycySqisLD/typ3Cik1/nfKqX92XezPAxQOyo5H+0VINbqsJrW/tvXch5BsrQeVm5yIgBey 4W5xtHCgsaC+OfQnCN6U50fn5oCHvDiEZiA3NvyKZTXdHIa93vdU2IHCNAAZ+VpnW+IJ X-Google-Smtp-Source: AGHT+IFicMKxh67gxTzJi5KsnyAX0MaJVbV4sO6l2PV0te1wj5kAx1PeIQnRAkPaJY4vbZm7hf8GBg== X-Received: by 2002:a05:6a00:21d6:b0:742:ae7e:7da1 with SMTP id d2e1a72fcca58-7489c2efd1bmr17627651b3a.0.1750169671547; Tue, 17 Jun 2025 07:14:31 -0700 (PDT) Received: from r760 ([188.253.126.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748900b2e30sm8838413b3a.128.2025.06.17.07.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 07:14:31 -0700 (PDT) From: Lidong Yan X-Google-Original-From: Lidong Yan <502024330056@smail.nju.edu.cn> To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Jun 2025 22:14:14 +0800 Message-ID: <20250617141416.950239-3-502024330056@smail.nju.edu.cn> X-Mailer: git-send-email 2.50.0-rc1 In-Reply-To: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lidong Yan <502024330056@smail.nju.edu.cn> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In config_input(), fir_to_phase() allocates memory in h[longer]. But if av_calloc() to s->coeffs failed, memory in h[longer] would leak. Add av_free(h[longer]) in !s->coeffs path. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> --- libavfilter/asrc_sinc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/asrc_sinc.c b/libavfilter/asrc_sinc.c index 6ff3303316..198c322665 100644 --- a/libavfilter/asrc_sinc.c +++ b/libavfilter/asrc_sinc.c @@ -370,8 +370,10 @@ static int config_output(AVFilterLink *outlink) s->n = 1 << (av_log2(n) + 1); s->rdft_len = 1 << av_log2(n); s->coeffs = av_calloc(s->n, sizeof(*s->coeffs)); - if (!s->coeffs) + if (!s->coeffs) { + av_free(h[longer]); return AVERROR(ENOMEM); + } for (i = 0; i < n; i++) s->coeffs[i] = h[longer][i]; -- 2.50.0-rc1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".