From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 033404D6A1 for ; Tue, 17 Jun 2025 14:14:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 79C0568D27B; Tue, 17 Jun 2025 17:14:36 +0300 (EEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D2F1068C32D for ; Tue, 17 Jun 2025 17:14:30 +0300 (EEST) Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-7406c6dd2b1so5941555b3a.0 for ; Tue, 17 Jun 2025 07:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750169669; x=1750774469; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qu62PnTmMMoylHTvNtMo+knHm1Js/VtMji4CP43hl4s=; b=A8cSrgqhlLxBn/XxQWwHfoJs6q0rQHIGWYdi+8cMh2KMcYehHVa/iWxOonyqyfU+Dn JRIYCo9wO23Nc5WevYfNI6Jub0q8UaIqba+W8PTQ2VlLYuRrS8I6E2MA75zwoyMBwHqY lPSTlmkZ+HhzcBpjhNbik4nZ7NwzHR9aYVP1yEOWW79OknP7R5G2DeLaoGoorA2L5+lO 8ZVtJ6JfjbvBSt370++fcCGsBqSVbP1WMA2tH8oDMPzPvAVvmfjqT4IZ3dkvZ0kBN1oV RbFlqwpxsHNE9HqZ5X/xwTrEJwyx04nBSGHDOnC24293O8OC607zNKfhRTmeCcQG/pxg CiJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750169669; x=1750774469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qu62PnTmMMoylHTvNtMo+knHm1Js/VtMji4CP43hl4s=; b=NGiZlha2BPQ3ANOLgRg2153TmnpagnB78DgsEhbF0Yn1kXC4gz8oUv2hL8cQ+5UECh pgEEXP05f+atVuLARMD9X7F0BAF1LnXTNp1SaRfKNvNTjTZDZuAczij+l99eTZxqYw7L 5ZHRhMHsmCH4Jy2aGmg+tyNlCBhwa798mz3bxZyRBGHiw7b9vq0GIlh4MnqgGJ3HoI1i OY/fHLVnUbLe9Ix5TbnM8DAjgii6JpIqIJgvRxG7+ulnCFlepEmibbfDR80IQjMAlUEx DdAvP+KKhb+tsBTf8oYIUv5iAxJGh5H4zQMnXhtUUwyigF8nOeAkrMHvpnQbp9JDjwRM g2gg== X-Gm-Message-State: AOJu0YwlQlS/pRq+yyghPnewLivnWt7NeXBnfVO3DQcSy2OOSCrz/+BW 4m5AfM+LGLS6LYV8kYl2MrkNuNCi1YSqYZjlFMBHSvfmRijZVwbhp8paupE6c/SuTw7OmcVG X-Gm-Gg: ASbGnctXy7HHSxHB4DiADkqteiWPIQHgFwCIX+74DsX5lZA0ZbC6OKJnNV7rk+Qqm/C CX59ZVYZj/+fgH0UywgnKSzf6C6GYt4NJf1uAnehR4wCtKPcgpPZkHqWf4IFuRmJggsTUJEFlNn siNx1PATWKMlu+FSq2fIXYFe2XL+7idpss1PUgSlLcek91R0PwtM3zzHnpt+rVm67MFVwLd8Vyy 4Per2xzta9OuuvoKpnY3+JJqtsT/UeKlEy97XKSlRV1oyGpmKG6y5uSL2P1ng56j02DDXQW4VdJ DM40m4cLNE5sCeVmrSChY1r++GN7hP7hOv+LOMZxtpMt4PkzvPm1L7B2rXTCsg2ReZxg X-Google-Smtp-Source: AGHT+IHn8xYgUjZ5sZRAOoohaHGf5VxHZlf2PB6fJAhOzq1U2nISkF5YtWIpFxKegKofptq/4VdTQA== X-Received: by 2002:a05:6a00:6217:b0:746:1c67:f6cb with SMTP id d2e1a72fcca58-748d14a14f8mr3129618b3a.5.1750169668847; Tue, 17 Jun 2025 07:14:28 -0700 (PDT) Received: from r760 ([188.253.126.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748900b2e30sm8838413b3a.128.2025.06.17.07.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 07:14:28 -0700 (PDT) From: Lidong Yan X-Google-Original-From: Lidong Yan <502024330056@smail.nju.edu.cn> To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Jun 2025 22:14:13 +0800 Message-ID: <20250617141416.950239-2-502024330056@smail.nju.edu.cn> X-Mailer: git-send-email 2.50.0-rc1 In-Reply-To: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/4] libavformat/rtmpproto: fix rmtp packet leak in gen_connect() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lidong Yan <502024330056@smail.nju.edu.cn> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In libavformat/rtmpproto.c:gen_connect(), if check on string length or check on codec fourcc failed, ff_rtmp_packet_create() allocated data in pkt would leak. Add ff_rtmp_packet_destory before return error code. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> --- libavformat/rtmpproto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 846376e668..dd850f72ed 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -347,6 +347,7 @@ static int gen_connect(URLContext *s, RTMPContext *rt) if ((fourcc_str_len + 1) % 5 != 0) { av_log(s, AV_LOG_ERROR, "Malformed rtmp_enhanched_codecs, " "should be of the form hvc1[,av01][,vp09][,...]\n"); + ff_rtmp_packet_destroy(&pkt); return AVERROR(EINVAL); } @@ -370,6 +371,7 @@ static int gen_connect(URLContext *s, RTMPContext *rt) ff_amf_write_string(&p, fourcc); } else { av_log(s, AV_LOG_ERROR, "Unsupported codec fourcc, %.*s\n", 4, fourcc_data); + ff_rtmp_packet_destroy(&pkt); return AVERROR_PATCHWELCOME; } -- 2.50.0-rc1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".