From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C9BEC4F44A for ; Tue, 17 Jun 2025 01:17:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C5E4468C9A2; Tue, 17 Jun 2025 04:17:35 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6546468C85B for ; Tue, 17 Jun 2025 04:17:28 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C138A443A4 for ; Tue, 17 Jun 2025 01:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750123047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XrZ6HTu3ktrYUXaC6LNSuVnhteMJ7ylbkTNOKm0d8L4=; b=O4rRx4j4CpbGQ+CF7PcXlX5KCIgEnopdDsJoBh+r1O5T3I5I51bzHtutzEsF3yi3d9Uv4I 3bCOc5nNWiai2QtRW/GIPo9ce08lNJNGlk4Jg/RHfeCiuF62U9PV9oKHP1Cv/bPJ8Gc6O6 zJn/AF/FeiOGR5ReMdblpaJE5qA4XnjI916CaL5AiZLwhdSU+/W5teRJizSxFIG4R6y9tX e+qTDqRLS6vUfyDMWS7hfwc13R+RGkFyCMZcS57DBMPbKznIeiSbhNyVocjP8hEhzfEgZt GXQk2MqmO3AaUTV9H0YPj5Ky4sI/Npn/LaTH5dEiXWaKa00Fp0Wdg5DFQGMtFQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 17 Jun 2025 03:17:24 +0200 Message-ID: <20250617011725.4109593-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617011725.4109593-1-michael@niedermayer.cc> References: <20250617011725.4109593-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddvkeduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepvdfgfeduieejteeijeekgfffhfdtleduueffvdefleeiveejteevudefteefjeefnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/osq: Add note about update_stats() count X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: It seems this is basically unused and unfinished code Signed-off-by: Michael Niedermayer --- libavcodec/osq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/osq.c b/libavcodec/osq.c index 14c723ed9c6..d3b1d86ee35 100644 --- a/libavcodec/osq.c +++ b/libavcodec/osq.c @@ -150,6 +150,8 @@ static void update_stats(OSQChannel *cb, int val) cb->history[cb->pos] = FFABS((int64_t)val); cb->pos++; cb->count++; + //NOTE for this to make sense count would need to be limited to FF_ARRAY_ELEMS(cb->history) + //Otherwise the average computation later makes no sense if (cb->pos >= FF_ARRAY_ELEMS(cb->history)) cb->pos = 0; } -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".