From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A2A494F1C6 for ; Mon, 16 Jun 2025 14:19:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A730568DD1A; Mon, 16 Jun 2025 17:18:56 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9114168DB93 for ; Mon, 16 Jun 2025 17:18:50 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 057A44393C for ; Mon, 16 Jun 2025 14:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1750083530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HrPoAgNV7dNLaMzsE2Xrcmn+zX8Q6/8umQuT2cV+jbc=; b=l7Qyx+s53tinEhjUup2E79uniOTo2vjXiTVksKGphAcmTVT1u+jQc61idCa4Eyk42z/a8u /nLuoPwdYfjKEjHRWz3HkTc+DrQgnFrmMOS1GcSJgOJL3J6b4ZKFyQydBFevrCJUzz/r6Y yHnigMy/eNvir1tyIL6oiM8dyOR28Q03oZB8aEYsmioVPNPEBMsrvMDR9jwVzoP8RNMX13 oSCH+GDoDuqzvb92C8oAfDiF8GVBGk+EtLQRF6/sbeFk3ycoTZXjMRuho24PVCF8KWj2WL Q7Hw/uj8UxFeGzy/GfJueSS8NvvFbbi2XQ6PUrdY31hZYZm2wLuRT2Kpc5U6cw== Date: Mon, 16 Jun 2025 16:18:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250616141849.GG29660@pb2> References: <20250616112003.10665-1-ffmpeg@haasn.xyz> <20250616112003.10665-7-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20250616112003.10665-7-ffmpeg@haasn.xyz> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddvieektdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3779634982007403107==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3779634982007403107== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vCOJZMXhGWhoSDM3" Content-Disposition: inline --vCOJZMXhGWhoSDM3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 16, 2025 at 01:19:55PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > Processes two channels in parallel, using 128-bit XMM registers. >=20 > In theory, we could go up to YMM registers to process 4 channels, but thi= s is > not a gain except for relatively high channel counts (e.g. 7.1), and also > complicates the sample load/store operations considerably. >=20 > I decided to only add an AVX variant, since the C code is not substantial= ly > slower enough to justify a separate function just for ancient CPUs. > --- > libavfilter/f_ebur128.c | 15 ++-- > libavfilter/f_ebur128.h | 16 ++++ > libavfilter/x86/Makefile | 4 + > libavfilter/x86/f_ebur128.asm | 142 +++++++++++++++++++++++++++++++ > libavfilter/x86/f_ebur128_init.c | 35 ++++++++ > 5 files changed, 207 insertions(+), 5 deletions(-) > create mode 100644 libavfilter/x86/f_ebur128.asm > create mode 100644 libavfilter/x86/f_ebur128_init.c breaks x86-32 build src/libavfilter/x86/f_ebur128.asm:116: error: symbol `m8' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:118: error: symbol `m9' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:119: error: symbol `m10' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:120: error: symbol `m11' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:121: error: symbol `m12' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:122: error: symbol `m13' undefined src//libavutil/x86/x86inc.asm:1638: ... from macro `movddup' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavfilter/x86/f_ebur128.asm:124: error: symbol `r7q' undefined src/libavfilter/x86/f_ebur128.asm:125: error: symbol `r8q' undefined src/libavfilter/x86/f_ebur128.asm:132: error: symbol `r7q' undefined =2E.. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --vCOJZMXhGWhoSDM3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaFAnxQAKCRBhHseHBAsP qzX2AJ94HcQ9csLR7Cr7dzQqma0k5kI2lgCeJQB7DmdPJdOFuLfC2ncU5iZ/6gk= =LkI8 -----END PGP SIGNATURE----- --vCOJZMXhGWhoSDM3-- --===============3779634982007403107== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3779634982007403107==--