From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E97A34F282 for ; Sun, 15 Jun 2025 20:50:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 52E8568D982; Sun, 15 Jun 2025 23:50:18 +0300 (EEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 08A4268CA5E for ; Sun, 15 Jun 2025 23:50:12 +0300 (EEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3121aed2435so4545821a91.2 for ; Sun, 15 Jun 2025 13:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020610; x=1750625410; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZQQ1kRYE1YJpLiL0Mv1tu8dkMKCb0SNxkzZ0dPxScHw=; b=YhfneJvxOAe8eCD1izsXh0jxbjilzUp4PPmHDVnHubwAQazqVJZ3gunlJzACB+v3qV 7V8XMfM4yV7ghA0sG9CZxgrGxEZyN+jEB6yfjJgHmQFI3y4Lh9yHscccDfXUtihFYedM t6W0yWVp+OaWtgZzWootczXKu4kngdhY0aKfw6WC207RL0zmHlpun1vjk5sLrKVY+/b7 7u16PKK0C1SZ+yctE9tPMxiWZzRdX+KklcXGjfah00hXx8yQwOsn3X8hVodlAB6nhfa3 o6/nnOsZCUZEZiB/VGLHbHmQutR8rpabDljfuOAf4ucYZlSuUsj5bBChwLPugmJIg32Y Z3Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020610; x=1750625410; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZQQ1kRYE1YJpLiL0Mv1tu8dkMKCb0SNxkzZ0dPxScHw=; b=v8kCc4s7NUua+3SSj/UaiXvnRtiXhQLulFqW/kvcCJkRjXFRo3E2W6y0ntqo6lIIHW 9eiXzG3hgA4hYszeb5bCpcsXAAmbp+3d71GfDwrQHb1lUhuU54ZuEYJi7ZDbdB7910lM DLj3Xya+++EMYpe7JU3F+3EqfSKdql1j0JPmtxvfin8b/w/CZPEzOc9PQzG/X352hmC0 TD4nLZwTYKfRVzVXwhoyblNrOvhGD+tdEcSHELo1qGB5HggcWymQWT9OiOe7Ojlr7Kit eAnPv8CqNV8DNWtHTatlkdXgUy9nck5gBzHHWoOIbfSe1VSwcHWG4QFvn8qOf3U1qCCB lQHQ== X-Gm-Message-State: AOJu0YxpsgpLW1+p4PhkX8HCLiM7YXnBeInuREVdLzwKiDc/ONPq7ygz e7IOb3yH477VXDZcyGrV6xTBDe1FSXs1611CpQqvO2wM0lzHEfJCS32uGt06kzRl X-Gm-Gg: ASbGncvXnw3Yz9mIRctaALpg4nW+BsqZOgxelArSJfch1D/8LFiXc4rxj+1LOn2CRZ4 lV0GFvbM0GTZQM3JIbEpTAgijPk4EiFPyoBVhG8O0x9xAsc5jBjarCRV9zoMEqvGqKvp+FZjsrY 74Vh6pKDbaBUWgmNdgYgjaxgFlIlpEIisxSiSND/Y0HTl+9rj+tIc0YaWGn/JTQuwg6zdq7Sf7I TtemKDKPjb7pTd0kcOrYijkdLPRN20oEBD6C+178Zw/b2Tq32h0pUS0wymefcJsb9OveppzM/ae 4nbVtXhQ/s/sd9YjArnmdjlL13CxNt7WT52mhBHLIAfsWVZ4sAVAxDJN3DJlzjyCwIGcNQEiNB0 K X-Google-Smtp-Source: AGHT+IFVlN65hy6APjN71PcQkHZNKtXhlDcZml9uWgJkTMwDnJrsxzzNqfo4RQfDyGHvn5sZEbimTg== X-Received: by 2002:a17:90b:50c7:b0:312:1c83:58ec with SMTP id 98e67ed59e1d1-313f1c0bcb0mr13531602a91.12.1750020609744; Sun, 15 Jun 2025 13:50:09 -0700 (PDT) Received: from homestead.aragog.com ([2605:a601:a9a2:a100:67c:16ff:fe02:37f0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1bcbb39sm7101899a91.8.2025.06.15.13.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:50:09 -0700 (PDT) From: Pavel Koshevoy To: ffmpeg-devel@ffmpeg.org Date: Sun, 15 Jun 2025 14:50:08 -0600 Message-ID: <20250615205008.17903-1-pkoshevoy@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/demux: Add allow_codec_changes option to AVFormatContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pavel Koshevoy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Make runtime AVStream.codecpar codec_id updates optional and disabled by default, so that avformat API clients can enable this feature explicitly when they add support for runtime codec changes. Accordingly, codec_close should not assume that the codec_id cannot change. This fixes 'ffprobe 1_poc.mp4' segfault introduced with commit 0021484d05f9b0f032fa319399de6e24eea0c04f --- doc/formats.texi | 6 ++++++ libavformat/avformat.h | 10 ++++++++++ libavformat/demux.c | 8 +++++++- libavformat/mpegts.c | 4 +++- libavformat/options_table.h | 1 + tests/fate/demux.mak | 2 +- 6 files changed, 28 insertions(+), 3 deletions(-) diff --git a/doc/formats.texi b/doc/formats.texi index 876a9e92b3..d18613f8bd 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -228,6 +228,12 @@ would require too many resources due to a large number of streams. Skip estimation of input duration if it requires an additional probing for PTS at end of file. At present, applicable for MPEG-PS and MPEG-TS. +@item allow_codec_changes @var{bool} (@emph{input}) +Allow AVStream.codecpar codec_type and codec_id to change at runtime +(for example when MPEG-TS PMT ES stream_type changes at runtime). +This is disabled by default, because most clients of avformat API +do not support random mid-stream codec changes. + @item duration_probesize @var{integer} (@emph{input}) Set probing size, in bytes, for input duration estimation when it actually requires an additional probing for PTS at end of file (at present: MPEG-PS and MPEG-TS). diff --git a/libavformat/avformat.h b/libavformat/avformat.h index b6c63e2237..c6956626b5 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1884,6 +1884,16 @@ typedef struct AVFormatContext { * @see skip_estimate_duration_from_pts */ int64_t duration_probesize; + + /** + * Allow AVStream.codecpar codec_type and codec_id to change at runtime + * (for example when MPEG-TS PMT ES stream_type changes at runtime). + * This is disabled by default, because most clients of avformat API + * do not support random mid-stream codec changes. + * - muxing: unused + * - demuxing: set by user + */ + int allow_codec_changes; } AVFormatContext; /** diff --git a/libavformat/demux.c b/libavformat/demux.c index ecd4f40da9..3749ab67a3 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -1292,9 +1292,15 @@ static int codec_close(FFStream *sti) { AVCodecContext *avctx_new = NULL; AVCodecParameters *par_tmp = NULL; + const AVCodec *new_codec = NULL; int ret; - avctx_new = avcodec_alloc_context3(sti->avctx->codec); + new_codec = + (sti->avctx->codec_id != sti->pub.codecpar->codec_id) ? + avcodec_find_decoder(sti->pub.codecpar->codec_id) : + sti->avctx->codec; + + avctx_new = avcodec_alloc_context3(new_codec); if (!avctx_new) { ret = AVERROR(ENOMEM); goto fail; diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index deb69a0548..0c78e870bb 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2510,7 +2510,9 @@ static void pmt_cb(MpegTSFilter *filter, const uint8_t *section, int section_len if (!st) goto out; - if (pes && pes->stream_type != stream_type) + if (pes && (!pes->stream_type || + (pes->stream_type != stream_type && + ts->stream->allow_codec_changes))) mpegts_set_stream_info(st, pes, stream_type, prog_reg_desc); add_pid_to_program(prg, pid); diff --git a/libavformat/options_table.h b/libavformat/options_table.h index e2e690fd2a..e949d60c3e 100644 --- a/libavformat/options_table.h +++ b/libavformat/options_table.h @@ -106,6 +106,7 @@ static const AVOption avformat_options[] = { {"skip_estimate_duration_from_pts", "skip duration calculation in estimate_timings_from_pts", OFFSET(skip_estimate_duration_from_pts), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, D}, {"max_probe_packets", "Maximum number of packets to probe a codec", OFFSET(max_probe_packets), AV_OPT_TYPE_INT, { .i64 = 2500 }, 0, INT_MAX, D }, {"duration_probesize", "Maximum number of bytes to probe the durations of the streams in estimate_timings_from_pts", OFFSET(duration_probesize), AV_OPT_TYPE_INT64, {.i64 = 0 }, 0, INT64_MAX, D}, +{"allow_codec_changes", "Allow AVStream.codecpar codec_type and codec_id to change at runtime", OFFSET(allow_codec_changes), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, D}, {NULL}, }; diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index ead5ad4b10..4a39e950b9 100644 --- a/tests/fate/demux.mak +++ b/tests/fate/demux.mak @@ -158,7 +158,7 @@ FATE_SAMPLES_DEMUX-$(CONFIG_XWMA_DEMUXER) += fate-xwma-demux fate-xwma-demux: CMD = crc -i $(TARGET_SAMPLES)/xwma/ergon.xwma -c:a copy FATE_FFPROBE_DEMUX-$(CONFIG_MPEGTS_DEMUXER) += fate-ts-demux -fate-ts-demux: CMD = ffprobe_demux $(TARGET_SAMPLES)/ac3/mp3ac325-4864-small.ts +fate-ts-demux: CMD = ffprobe_demux $(TARGET_SAMPLES)/ac3/mp3ac325-4864-small.ts -allow_codec_changes 1 FATE_FFPROBE_DEMUX-$(CONFIG_MPEGTS_DEMUXER) += fate-ts-timed-id3-demux fate-ts-timed-id3-demux: CMD = ffprobe_demux $(TARGET_SAMPLES)/mpegts/id3.ts -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".