Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Sun, 15 Jun 2025 00:57:13 +0200
Message-ID: <20250614225713.GP29660@pb2> (raw)
In-Reply-To: <20250604165852.75087-1-romain.beauxis@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]

On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote:
> This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a flat
> memory storage for the extradata.
> 
> PR review comments addressed:
> * Use flat memory bytestream
> * Re-use existing xiph extradata layout
> 
> ---

>  libavcodec/vorbisdec.c                     | 42 ++++++++---
>  libavformat/oggparsevorbis.c               | 83 +++++++++++++++++++++-

patches that change both libraries at the same time are suspect

if one depends on changes in the other it needs
minor API version bump and seperate patches so extension of
API and use of it are properly tracked and testable

have not reveiwed the rest of the patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".