Re: [FFmpeg-devel] [PATCH] add yuv444p support to mcdeint

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1617 bytes --]

On Sun, Jun 08, 2025 at 01:07:37AM -0500, Ethan Halsall wrote:
> Hi Michael,
> 
> On 6/7/25 6:25 PM, Michael Niedermayer wrote:
> > Hi Ethan
> > 
> > On Sat, Jun 07, 2025 at 12:15:06PM -0500, Ethan Halsall wrote:
> >> Hi Michael,
> > [...]
> >> @@ -201,8 +203,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *inpic)
> >>  
> >>      for (i = 0; i < 3; i++) {
> >>          int is_chroma = !!i;
> >> -        int w = AV_CEIL_RSHIFT(inlink->w, is_chroma);
> >> -        int h = AV_CEIL_RSHIFT(inlink->h, is_chroma);
> >> +        int w, h;
> >> +        if (is_chroma) {
> >> +            w = inlink->w >> pix_fmt_desc->log2_chroma_w;
> >> +            h = inlink->h >> pix_fmt_desc->log2_chroma_h;
> > 
> > why is this not using AV_CEIL_RSHIFT() ?
> > 
> > thx
> > 
> > [...]
> > 
> > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> I was just using a plain right shift as I was experimenting with this. Seems to work fine with the macro so I can put it back if that's more conventional.

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The day soldiers stop bringing you their problems is the day you have stopped 
leading them. They have either lost confidence that you can help or concluded 
you do not care. Either case is a failure of leadership. - Colin Powell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".