Re: [FFmpeg-devel] [PATCH] avcodec/h264: fixed qp table attach for h264

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

On Fri, Jun 13, 2025 at 02:37:53PM +0200, Timothee wrote:
> Hello,
> 
> Here is a patch where I fixed the attach of per-macroblock qp tables for
> H.264. It was implemented for MPEG2 so I have only extended it.
> 
> I tested the functionality with the codecview filter using the following
> command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=qp=1
> output.mp4`
> 
> FATE passes.
> 
> Thanks,
> Timothée
> 
> Signed-off-by: Timothee <timothee.informatique@regaud-chapuy.fr>
> ---
>  libavcodec/h264_slice.c | 16 ++++++++++++----
>  libavfilter/qp_table.c  |  3 ++-
>  libavfilter/qp_table.h  |  1 +
>  3 files changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index 7e53e38cca..f217c58837 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -2615,8 +2615,10 @@ static int decode_slice(struct AVCodecContext *avctx,
> void *arg)
>               ret = ff_h264_decode_mb_cabac(h, sl);
>  -            if (ret >= 0)
> +            if (ret >= 0) {

Applying: avcodec/h264: fixed qp table attach for h264
error: corrupt patch at line 20
error: could not build fake ancestor

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What is kyc? Its a tool that makes you give out your real ID, while criminals
give out a forged ID card.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".