From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1B7134EF0C for ; Fri, 13 Jun 2025 20:46:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EA0C168CAF5; Fri, 13 Jun 2025 23:46:55 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 800D468C9A7 for ; Fri, 13 Jun 2025 23:46:48 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 893E144531; Fri, 13 Jun 2025 20:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1749847607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1mKCWgvxQEnrtxN8h64pfd4gZ9pNPUl4TR1X4mOEtCc=; b=GxPwQrfdm0Rkvk15DaulLRuy3+s7NjW2y0V4ZtAMFPXVsxS+IHwcspps6TtxWIQrvRW45t TUkeWbuKYcr8clf7VFxHwb542lFqbWpZgyXYCpk2Qk9LeD2eJXQ5yPEm/Od4PWAVYihuEL uSEJX28DjTy+3iuwcZdJzZHNdjQEYYOLPAgVJirutTKk1QM2YPim/AbiY0jSNkoEMZoaPz 51EIw/woW3XvjDnpJsL4wbtcNFYnMyCiN5EuTIXlbwNyirAcBZz4N8zxH9JJbdk85QVdxe tGcUv5nOIKj+7iuoYV0LR3aFBAHlHfu6EAp1QlMVdWSaITkSf8K/WTzxtQhAjw== Date: Fri, 13 Jun 2025 22:46:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250613204646.GG29660@pb2> References: <20250609122551.1373509-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20250609122551.1373509-1-michael@niedermayer.cc> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddukeelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeltdeihedthfeutdfhgeejtdelvefgudffuddvudffgfdthedtudegudeihfejtdenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepvddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhgpdhrtghpthhtohepphhkohhshhgvvhhohiesghhmrghilhdrtghomh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pavel Koshevoy Content-Type: multipart/mixed; boundary="===============2180846129738794903==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2180846129738794903== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v1AS/hO19+mH7c1F" Content-Disposition: inline --v1AS/hO19+mH7c1F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > This fixes mixing up contexts, use of uninitialized data and crashes. > More specifically: >=20 > =3D=3D1001752=3D=3D Conditional jump or move depends on uninitialised val= ue(s) > =3D=3D1001752=3D=3D at 0xA9ED82: avpriv_h264_has_num_reorder_frames (h= 264dec.c:64) > =3D=3D1001752=3D=3D by 0x668C7E: has_decode_delay_been_guessed (demux.= c:757) > =3D=3D1001752=3D=3D by 0x66AB13: compute_pkt_fields (demux.c:1137) > =3D=3D1001752=3D=3D by 0x66B2E9: parse_packet (demux.c:1265) > =3D=3D1001752=3D=3D by 0x66BD84: read_frame_internal (demux.c:1449) > =3D=3D1001752=3D=3D by 0x67085B: avformat_find_stream_info (demux.c:26= 92) > =3D=3D1001752=3D=3D by 0x25157C: ifile_open (ffmpeg_demux.c:1814) > =3D=3D1001752=3D=3D by 0x272B15: open_files (ffmpeg_opt.c:1366) > =3D=3D1001752=3D=3D by 0x272D85: ffmpeg_parse_options (ffmpeg_opt.c:14= 15) > =3D=3D1001752=3D=3D by 0x2925C9: main (ffmpeg.c:991) > =3D=3D1001752=3D=3D Uninitialised value was created by a heap allocation > =3D=3D1001752=3D=3D at 0x483E0F0: memalign (in /usr/lib/x86_64-linux-g= nu/valgrind/vgpreload_memcheck-amd64-linux.so) > =3D=3D1001752=3D=3D by 0x483E212: posix_memalign (in /usr/lib/x86_64-l= inux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > =3D=3D1001752=3D=3D by 0x14882CE: av_malloc (mem.c:107) > =3D=3D1001752=3D=3D by 0x1463785: av_buffer_alloc (buffer.c:82) > =3D=3D1001752=3D=3D by 0x146423F: pool_alloc_buffer (buffer.c:369) > =3D=3D1001752=3D=3D by 0x14643C4: av_buffer_pool_get (buffer.c:407) > =3D=3D1001752=3D=3D by 0x752C4B: buffer_pool_get (mpegts.c:1142) > =3D=3D1001752=3D=3D by 0x7538F2: mpegts_push_data (mpegts.c:1407) > =3D=3D1001752=3D=3D by 0x758893: handle_packet (mpegts.c:2909) > =3D=3D1001752=3D=3D by 0x758E90: handle_packets (mpegts.c:3048) > =3D=3D1001752=3D=3D by 0x759B1D: mpegts_read_packet (mpegts.c:3290) > =3D=3D1001752=3D=3D by 0x6687A3: ff_read_packet (demux.c:649) > =3D=3D1001752=3D=3D by 0x66B594: read_frame_internal (demux.c:1346) > =3D=3D1001752=3D=3D by 0x67085B: avformat_find_stream_info (demux.c:26= 92) > =3D=3D1001752=3D=3D by 0x25157C: ifile_open (ffmpeg_demux.c:1814) > =3D=3D1001752=3D=3D by 0x272B15: open_files (ffmpeg_opt.c:1366) > =3D=3D1001752=3D=3D by 0x272D85: ffmpeg_parse_options (ffmpeg_opt.c:14= 15) > =3D=3D1001752=3D=3D by 0x2925C9: main (ffmpeg.c:991) >=20 > Found-by: Alexander A. Shvedov > CC: Pavel Koshevoy > This reverts commit 0021484d05f9b0f032fa319399de6e24eea0c04f. > --- > libavformat/mpegts.c | 4 +--- > tests/ref/fate/ts-demux | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) does anyone object to this ? Pavel, are you ok with this being reverted or do you want to submit a patch that puts this behind some runtime flag ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope --v1AS/hO19+mH7c1F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaEyONgAKCRBhHseHBAsP q+FSAJ90DUjSFPOrMvD1p2NONLX29cqWuwCffiXxM2pFybwWWwFUNuV8pfjidqk= =OSF0 -----END PGP SIGNATURE----- --v1AS/hO19+mH7c1F-- --===============2180846129738794903== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2180846129738794903==--