From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 055144EED4 for ; Fri, 13 Jun 2025 20:03:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5114368CA8A; Fri, 13 Jun 2025 23:03:06 +0300 (EEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8200C68C83F for ; Fri, 13 Jun 2025 23:02:59 +0300 (EEST) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4a43afb04a7so20253591cf.0 for ; Fri, 13 Jun 2025 13:02:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749844978; x=1750449778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j67chANzywhJPJIgSv4AOCM8kT3CdnbM4TYrYsYCt4A=; b=u/9SQM2Tmqkou4zWom8sj1sCa/uaJjnHOJ54h+XZjyZZugPAZrBonFz+VKXjIUtbrR oocoKULnzq7hdxNHHVotip/jdcUQDl+hxOueVB7Kqseb94Wg8oJIdwnkyNevGndoIyGa Glg+emet4ThLq5hLPx1kbqkh2q+8j66AXyaBf172LmQZSDOpJ6SOkBYSQS8N+YM5sFzA V0NeNDObK5vkNe9O8I7E/mSzC+YaQN8+SKHoC7Ib5MFqGqcCghpNr1ulTnnSLeP+iO1r CRM+hWTw7b+7LxXwtOlvNZV71PfeHJ0pxhDt8NMxmnse0lnDuC4miNV1ACvoY+xgf0q0 wFHg== X-Gm-Message-State: AOJu0YytsLJ3nIRBNSZCgNugrh2pQ258JEcmu1smjP/0cGfS5Gdi0GH3 eer5O0RZMmGfVF3FMJqSZN9S0QahiloYBxi3RaHqM+yeAbA5czE+XI/kXNvImIFq X-Gm-Gg: ASbGncuP9BVPtFYU99b0G1Ci6B2u4N/UvJMmjuiTp4oZwjqEWLzU3nKcOEQrAjVCN+u aA+ZghyADlRDIxfMhBte8NBGM8DkbOxNSAJDPfeVizcnvFwbR+JjDiasH+VNaZKBDCCk79Ovj83 ulnRtxlcpdELqTxbyJamL1m0Dhun7iqcBH7V1OwjT5u13W0kGRG9RJJr9qJV+txjNxmRF5qV1GS /GTyFlkHacKpmqs1P0cBpm30cp3H/OXd7SB1yJoblOOXN2GeRGqRCQFdrOPv6Z5tEjW8+39rrO/ 7S83SPApA79hnzatg4xDuu+Rf/JxY40H0r2ITuA7wHOK3NXaH29i1cPzfg== X-Google-Smtp-Source: AGHT+IGswt8zZeB0hgjXEnX1wusXqrbrdlt+wCBMGROibwwG66eNK/+9dTHKOauPflCkRRtV9qFpvQ== X-Received: by 2002:ac8:5f0e:0:b0:4a5:912a:7c64 with SMTP id d75a77b69052e-4a73c58f3e9mr8591381cf.30.1749844977516; Fri, 13 Jun 2025 13:02:57 -0700 (PDT) Received: from bellini.. ([198.58.151.12]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a72a4cfe45sm20788081cf.55.2025.06.13.13.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 13:02:56 -0700 (PDT) From: Tristan Matthews To: ffmpeg-devel@ffmpeg.org Date: Fri, 13 Jun 2025 16:02:33 -0400 Message-ID: <20250613200241.2994917-1-tmatth@videolan.org> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] h264dsp: h264_luma_dc_dequant_idct: constify input X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tristan Matthews Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --- libavcodec/h264dsp.h | 2 +- libavcodec/h264idct.h | 2 +- libavcodec/h264idct_template.c | 2 +- libavcodec/loongarch/h264dsp_loongarch.h | 2 +- libavcodec/loongarch/h264idct.S | 2 +- libavcodec/mips/h264dsp_mips.h | 2 +- libavcodec/mips/h264dsp_mmi.c | 2 +- libavcodec/x86/h264_idct.asm | 2 +- libavcodec/x86/h264dsp_init.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264dsp.h b/libavcodec/h264dsp.h index 4a9cb1568d..4733288b4a 100644 --- a/libavcodec/h264dsp.h +++ b/libavcodec/h264dsp.h @@ -100,7 +100,7 @@ typedef struct H264DSPContext { int16_t *block /*align 16*/, int stride, const uint8_t nnzc[5 * 8]); void (*h264_luma_dc_dequant_idct)(int16_t *output, - int16_t *input /*align 16*/, int qmul); + const int16_t *input /*align 16*/, int qmul); void (*h264_chroma_dc_dequant_idct)(int16_t *block, int qmul); /* bypass-transform */ diff --git a/libavcodec/h264idct.h b/libavcodec/h264idct.h index 6f18df9e5f..8e0b21561a 100644 --- a/libavcodec/h264idct.h +++ b/libavcodec/h264idct.h @@ -31,7 +31,7 @@ void ff_h264_idct_add16intra_ ## depth ## _c(uint8_t *dst, const int *blockoffse void ff_h264_idct8_add4_ ## depth ## _c(uint8_t *dst, const int *blockoffset, int16_t *block, int stride, const uint8_t nnzc[5 * 8]);\ void ff_h264_idct_add8_422_ ## depth ## _c(uint8_t **dest, const int *blockoffset, int16_t *block, int stride, const uint8_t nnzc[15 * 8]);\ void ff_h264_idct_add8_ ## depth ## _c(uint8_t **dest, const int *blockoffset, int16_t *block, int stride, const uint8_t nnzc[15 * 8]);\ -void ff_h264_luma_dc_dequant_idct_ ## depth ## _c(int16_t *output, int16_t *input, int qmul);\ +void ff_h264_luma_dc_dequant_idct_ ## depth ## _c(int16_t *output, const int16_t *input, int qmul);\ void ff_h264_chroma422_dc_dequant_idct_ ## depth ## _c(int16_t *block, int qmul);\ void ff_h264_chroma_dc_dequant_idct_ ## depth ## _c(int16_t *block, int qmul); diff --git a/libavcodec/h264idct_template.c b/libavcodec/h264idct_template.c index db19b5f9fb..72fec8253b 100644 --- a/libavcodec/h264idct_template.c +++ b/libavcodec/h264idct_template.c @@ -248,7 +248,7 @@ void FUNCC(ff_h264_idct_add8_422)(uint8_t **dest, const int *block_offset, int16 * IDCT transforms the 16 dc values and dequantizes them. * @param qmul quantization parameter */ -void FUNCC(ff_h264_luma_dc_dequant_idct)(int16_t *_output, int16_t *_input, int qmul){ +void FUNCC(ff_h264_luma_dc_dequant_idct)(int16_t *_output, const int16_t *_input, int qmul){ #define stride 16 int i; int temp[16]; diff --git a/libavcodec/loongarch/h264dsp_loongarch.h b/libavcodec/loongarch/h264dsp_loongarch.h index e17522dfe0..d51d27fe17 100644 --- a/libavcodec/loongarch/h264dsp_loongarch.h +++ b/libavcodec/loongarch/h264dsp_loongarch.h @@ -30,7 +30,7 @@ void ff_h264_idct_add_8_lsx(uint8_t *dst, int16_t *src, int dst_stride); void ff_h264_idct8_add_8_lsx(uint8_t *dst, int16_t *src, int dst_stride); void ff_h264_idct_dc_add_8_lsx(uint8_t *dst, int16_t *src, int dst_stride); void ff_h264_idct8_dc_add_8_lsx(uint8_t *dst, int16_t *src, int dst_stride); -void ff_h264_luma_dc_dequant_idct_8_lsx(int16_t *_output, int16_t *_input, int qmul); +void ff_h264_luma_dc_dequant_idct_8_lsx(int16_t *_output, const int16_t *_input, int qmul); void ff_h264_idct_add16_8_lsx(uint8_t *dst, const int32_t *blk_offset, int16_t *block, int32_t dst_stride, const uint8_t nzc[15 * 8]); diff --git a/libavcodec/loongarch/h264idct.S b/libavcodec/loongarch/h264idct.S index f504cfb714..0c9082e20c 100644 --- a/libavcodec/loongarch/h264idct.S +++ b/libavcodec/loongarch/h264idct.S @@ -612,7 +612,7 @@ endfunc /** * IDCT transforms the 16 dc values and dequantizes them. * @param qmul quantization parameter - * void FUNCC(ff_h264_luma_dc_dequant_idct)(int16_t *_output, int16_t *_input, int qmul){ + * void FUNCC(ff_h264_luma_dc_dequant_idct)(int16_t *_output, const int16_t *_input, int qmul){ * LSX optimization is enough for this function. */ function ff_h264_luma_dc_dequant_idct_8_lsx diff --git a/libavcodec/mips/h264dsp_mips.h b/libavcodec/mips/h264dsp_mips.h index 4a2a2c2559..0edfad4434 100644 --- a/libavcodec/mips/h264dsp_mips.h +++ b/libavcodec/mips/h264dsp_mips.h @@ -338,7 +338,7 @@ void ff_h264_idct_add8_8_mmi(uint8_t **dest, const int *block_offset, int16_t *block, int stride, const uint8_t nnzc[15*8]); void ff_h264_idct_add8_422_8_mmi(uint8_t **dest, const int *block_offset, int16_t *block, int stride, const uint8_t nnzc[15*8]); -void ff_h264_luma_dc_dequant_idct_8_mmi(int16_t *output, int16_t *input, +void ff_h264_luma_dc_dequant_idct_8_mmi(int16_t *output, const int16_t *input, int qmul); void ff_h264_weight_pixels16_8_mmi(uint8_t *block, ptrdiff_t stride, int height, diff --git a/libavcodec/mips/h264dsp_mmi.c b/libavcodec/mips/h264dsp_mmi.c index bae1052dcf..c1c17867fe 100644 --- a/libavcodec/mips/h264dsp_mmi.c +++ b/libavcodec/mips/h264dsp_mmi.c @@ -857,7 +857,7 @@ void ff_h264_idct_add8_422_8_mmi(uint8_t **dest, const int *block_offset, } } -void ff_h264_luma_dc_dequant_idct_8_mmi(int16_t *output, int16_t *input, +void ff_h264_luma_dc_dequant_idct_8_mmi(int16_t *output, const int16_t *input, int qmul) { double ftmp[10]; diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index d9c3c9c862..a8160b4ccc 100644 --- a/libavcodec/x86/h264_idct.asm +++ b/libavcodec/x86/h264_idct.asm @@ -612,7 +612,7 @@ cglobal h264_idct_add8_8, 5, 7 + ARCH_X86_64, 8 add8_sse2_cycle 3, 0x64 RET -;void ff_h264_luma_dc_dequant_idct_mmx(int16_t *output, int16_t *input, int qmul) +;void ff_h264_luma_dc_dequant_idct_mmx(int16_t *output, const int16_t *input, int qmul) %macro WALSH4_1D 5 SUMSUB_BADC w, %4, %3, %2, %1, %5 diff --git a/libavcodec/x86/h264dsp_init.c b/libavcodec/x86/h264dsp_init.c index dc8fc4f720..f8cfeb965f 100644 --- a/libavcodec/x86/h264dsp_init.c +++ b/libavcodec/x86/h264dsp_init.c @@ -76,7 +76,7 @@ IDCT_ADD_REP_FUNC2(, 8_422, 8, mmx) IDCT_ADD_REP_FUNC2(, 8_422, 10, sse2) IDCT_ADD_REP_FUNC2(, 8_422, 10, avx) -void ff_h264_luma_dc_dequant_idct_sse2(int16_t *output, int16_t *input, int qmul); +void ff_h264_luma_dc_dequant_idct_sse2(int16_t *output, const int16_t *input, int qmul); /***********************************/ /* deblocking */ -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".