From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A35EA4CD8D for ; Fri, 13 Jun 2025 10:57:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8796E68C5F6; Fri, 13 Jun 2025 13:57:17 +0300 (EEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1D61D68C58A for ; Fri, 13 Jun 2025 13:57:11 +0300 (EEST) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30f30200b51so19639731fa.3 for ; Fri, 13 Jun 2025 03:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1749812230; x=1750417030; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=R0s7zYlU6p1XUHYsy/CrkHT1ZI5cTeTzO8vE7I+CIXE=; b=nfkC0bQbsmiYAbXgQ6hiqyY9r78dSuliK9ZBFnjpOoMu/q4woqBvNE55fXOzn7879u vCmiXBSSVmMY8ZbeynapiO4mB1Cq4VYPrQoiYYASB/xlrfPkJbig2t7IYXrq5NEkyo0q TCh28Z1Q7oJqimImBTVbeVi7R6uH/Nzh1A1phO7M5N2q0by43f7F1Rh60tiDeq+3MUYf LkDCQKEB3s7Uz6D//x3GNyOzpjjvVeFMW/Om4ewOx3/xZBm1orLqjF7gwrxsEsITZPbo F6QUfUKVtFhDa1Pr1Q+IRiOcLyMnzA98+3ZlDvnjS7aQ3j4pUD5XkuwnYA9wrbZRKYP7 MeFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749812230; x=1750417030; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R0s7zYlU6p1XUHYsy/CrkHT1ZI5cTeTzO8vE7I+CIXE=; b=SykC4IxGkVpybe7LJ5y9ZzzWqkJ6TuOKYlit299NkoX/1GubU9yUED7FFjQEiJYNFC OunueGh5HH95OPExaxgXEwhbVyA49wvvE3UZ97wEbW236kmzEFr1fIfcM90nrxrKG2q/ ocy5DpYxBiO93CLwTz3po5IIWKblri0YR6LqLA9PfV0KNOXJPc2xVO1uMBr71eIHpqSc 5kjfGpA49GbBaVWkznp3HQLcu4T5lFGg81T+NPFjfXilhX4i3SKQpuKM7OaKog04iWHC jF440OGzp9pw39LQC9qIcEMkbNBZVFf6m8JA8Nnhc3FrYmf7TYxQFEuLoAwBAe4t7C6V pP5A== X-Gm-Message-State: AOJu0YyZxrG5PsU5DAphn8OD8G1bwS3/4Epeg7nxeQAFmicclHK+HlIv 9Xb+U3eMX/AyCOPLvLXhxxEe6rBunKpb/fhFSRMkX2otbl7xwcw+ttIwFNsqYls8RZuAO66MfXi 5UvsdFQ== X-Gm-Gg: ASbGncsKLjNOYT5JG2HYLRBehVSLOGyQvtBZ8028y2lTJDWx4uO7QHeicxWiKw4xrBp ZT7pk63UsmpiLfO66dQ76OAObxWmX9ER/WBZ796+l8rZH5iCsxERD3VmTymPoGEx0N/l/LYdcn6 dqtB3l+aVVb9z9kf9YvbMMZl1FM2yUfu6dFp9zgVx3qr9eoOVjAUUkxIohWDMOGPPJnQ7j4uhG6 +YhXHN4WkmyPTGrCzt4XiBN1v5M6oH2419P1GQCLNcNqncEP1km9Qy76J8FzkMG4Nh9fk4J7dNs 7VKdt2qvhUs5o1C73I/NzDP9LyEqXbgae8eoSLOM7AMZGhIH9JzpLxqat+PRa985M/OdLo1X7D6 d10bnFLnevQ37FFfF5A== X-Google-Smtp-Source: AGHT+IHc0BGDUMBaXaC++pvZ0BqDk8INr9Ak55i85A5tCuYs8vasAMrZZzqjOH/bn8KAitIyd6jQ/g== X-Received: by 2002:a05:651c:1543:b0:327:fec0:b85d with SMTP id 38308e7fff4ca-32b3eb1c7d2mr6969451fa.21.1749812229755; Fri, 13 Jun 2025 03:57:09 -0700 (PDT) Received: from localhost (dsl-tkubng21-50de30-198.dhcp.inet.fi. [80.222.48.198]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32b3316fbd6sm4978651fa.56.2025.06.13.03.57.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 03:57:09 -0700 (PDT) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 13 Jun 2025 13:57:05 +0300 Message-ID: <20250613105709.2065708-1-martin@martin.st> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [FATE PATCH] Properly list test errors when there are no failed tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: If there were failures while running tests, e.g. if failing to compile checkasm or any other of the test programs, there are no failed tests per se, and the number of succeessful tests is equal to the total number of tests. For these cases, check the job status code instead of declaring them as a full success. --- history.cgi | 2 +- index.cgi | 2 +- report.cgi | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/history.cgi b/history.cgi index 533999c..d0a855d 100755 --- a/history.cgi +++ b/history.cgi @@ -76,7 +76,7 @@ for my $date ((sort { $b cmp $a } @reps)[0..49]) { td $$rep{nwarn}; if ($npass) { $rtext = "$npass / $ntest"; - $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail'; + $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail'; } elsif (!$ntest and !$$rep{status}) { $rtext = "build only"; $rclass = $$rep{status}? 'fail' : 'pass'; diff --git a/index.cgi b/index.cgi index 25c61e9..89e599a 100755 --- a/index.cgi +++ b/index.cgi @@ -286,7 +286,7 @@ for my $rep (sort repcmp @reps) { td $$rep{comment}, class => 'comment'; if ($npass) { $rtext = "$npass / $ntest"; - $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail'; + $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail'; } elsif (!$ntest and !$$rep{status}) { $rtext = "build only"; $rclass = $$rep{status}? 'fail' : 'pass'; diff --git a/report.cgi b/report.cgi index 5a2394d..ca003b1 100755 --- a/report.cgi +++ b/report.cgi @@ -183,7 +183,11 @@ if ($nfail) { } end 'tbody'; } elsif ($ntest) { - start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end; + if ($$hdr{status}) { + start 'tr', class => 'fail'; th 'Failure building tests', colspan => 3; end; + } else { + start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end; + } } else { my $class = $$hdr{status}? 'fail' : 'pass'; start 'tr', class => $class; th 'No tests were run', colspan => 3; end; -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".