From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AF84F4E79A for ; Wed, 11 Jun 2025 19:57:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 17DEB68B0ED; Wed, 11 Jun 2025 22:57:44 +0300 (EEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 15B9068A76F for ; Wed, 11 Jun 2025 22:57:38 +0300 (EEST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so852775e9.2 for ; Wed, 11 Jun 2025 12:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749671857; x=1750276657; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yXH2ajYwb5wm+GsHfhAjrDBnBEnC3rBxNr3TCy7jlH0=; b=OqmIrKmjy2SXHx14RAjVkFK/P3ngtNGgZZdGBzCvQBdOsB6+vjQsKIyAcgZzVYmLKa bthckGQQuj5qeG9MYy3sbETv4AvrZqWA/rxDOOrW68e/ox7jv4Nr17atspypeqhmebxF jZvO3g6I+L8Wo8fxJOLGOjiHOWL5EXToUueel5HyqmLa0bk4/SIvwGo9PttK5+51UaQm O1suiqI7zF5Trj1QxqP1Y3MWvWrZ7om8Dcz2g3pw/gIz3m4wXJKYTNJIR8NdC2UasaPA tV7IwI8fwxA/fVRekx9z/ZhzMDB9hAHdGoNYftnz4OuyaA2Ivvwx16Z0NW+N62tDAIsi S80w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749671857; x=1750276657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yXH2ajYwb5wm+GsHfhAjrDBnBEnC3rBxNr3TCy7jlH0=; b=GzAiJAaegqUp7mXdxgYTOG8akmR+kYHRdNGpaw6TmOolei7Mrlm8VV8BcUynUblGJ/ WpHdo7yn2JxKB0By8N7iwfuiomdplEqQK/gB6i7Rh7uh+VWmmItSLzNCMZ+oqrErmxmg Ioibqbgkl/BgJCl/CQ9RsJyzY1Nus71aLnWhF/HIZkV1oyH4TgwOzN2f7pRx6kQr4QGD qROguhJo3jd3SKQIgqpIcDEpuLO1CtED6+Ex4gOfgI24Us8z3s7zzx/q24RSszVbJk8L clK4KF963yjBbWc2fXZ7mYcMSYxwBj/joFdRlXJC6p1ZOE6RHm7QxISfjsBp3izNbIgv mFpg== X-Gm-Message-State: AOJu0YwiW/b3jBWT2gm9NHB9OsDlqMkTkX14HTSe/YF9mvgdaiEUJCUG sVqozDasojj6+nTjTm5q+texjKAWHPYfo1Z98ZxWPbRX4cSIUKUMOObb8et+LA== X-Gm-Gg: ASbGncuIdl5A1hszz2jajfBbWjuN5nIylaoAprslGvhYN+S6K8X0pr31ZRLrsQZ8lW9 A4rrqrKh9WoE9sCqOPIVkIPomWJpwvynkgbC0xcWDBVWwxnwDExoOg3/3wi3YFesiuPruQtBiOa vK1Z+SoJVYOv7BL7mTyp6SEBgkey0L99qrP1M+MCkZEIDQrmFa+36FZ/iNRBC413TupxHxs8MzX 3FIBSMZdBxG+k4eWB3hdWlkt6ojnjXHiJnyUdOXupimpoxR1r1X5pyp1t/Ck+OPCoPftGOXIkMS ZK/7tHcBErfBmi2+G5DV2D8yfXFg+sdPBLK5hofb3cvMQ2hD2YdpYo7kK1MmWtLE06fQnveXGav CUmFVRP1KhQQyOBwJtyTB8FdzbIB1ZIvLGI3E5Pb5ZFMvAm1QT4PZXYHSUuXcbjovuPxkGwrOj3 5P2VhqBg== X-Google-Smtp-Source: AGHT+IHvwMTsFdEX2aJOaGwEvwdnzYICYzsnwAWw1hbclMUuPMz0t4CCT1d/RIMBIRi/W1o+K5L5Fw== X-Received: by 2002:a05:600c:8012:b0:43d:94:2d1e with SMTP id 5b1f17b1804b1-4532487a6b7mr47809255e9.13.1749671857194; Wed, 11 Jun 2025 12:57:37 -0700 (PDT) Received: from localhost.localdomain (p200301023700450060f2a9d7350ce887.dip0.t-ipconnect.de. [2003:102:3700:4500:60f2:a9d7:350c:e887]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244f04dsm16232467f8f.73.2025.06.11.12.57.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Jun 2025 12:57:36 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 Jun 2025 21:57:23 +0200 Message-Id: <20250611195725.95154-2-epirat07@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250611195725.95154-1-epirat07@gmail.com> References: <20250611195725.95154-1-epirat07@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Doesn't change the logic, instead of exiting in each of the two branches below, just exit before. --- fftools/textformat/tf_mermaid.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index 59b11811f1..dbe489a7a7 100644 --- a/fftools/textformat/tf_mermaid.c +++ b/fftools/textformat/tf_mermaid.c @@ -579,15 +579,11 @@ static void mermaid_print_value(AVTextFormatContext *tfc, const char *key, exit = 1; } - //if (exit) - // return; + if (exit) + return; if ((section->flags & (AV_TEXTFORMAT_SECTION_FLAG_IS_SHAPE | AV_TEXTFORMAT_SECTION_PRINT_TAGS)) || (section->flags & AV_TEXTFORMAT_SECTION_FLAG_IS_SUBGRAPH && sec_data.subgraph_start_incomplete)) { - - if (exit) - return; - switch (mmc->diagram_config->diagram_type) { case AV_DIAGRAMTYPE_GRAPH: @@ -630,10 +626,6 @@ static void mermaid_print_value(AVTextFormatContext *tfc, const char *key, } } else if (section->flags & AV_TEXTFORMAT_SECTION_FLAG_HAS_LINKS) { - - if (exit) - return; - if (buf->len > 0) av_bprintf(buf, "%s", "
"); -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".