From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BDC0F4E7D8 for ; Wed, 11 Jun 2025 19:57:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BC14F68A5E4; Wed, 11 Jun 2025 22:57:42 +0300 (EEST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4C080688FDB for ; Wed, 11 Jun 2025 22:57:36 +0300 (EEST) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a53ee6fcd5so169771f8f.1 for ; Wed, 11 Jun 2025 12:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749671855; x=1750276655; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=cqMCLZyOkpRAbmSd1eEk7hYlIDeFqlCFB/I/s26FVVE=; b=duIoux8Pksq/xd2CEc/1f6cJDgLkcaQ5GOPbmHTsrBd9VagTh4pHnrhhBxqE8NweNP YWN8tDfbCdonisSrFeJPgfXsIF9KqkACZ8OCMXBqh09pTAh3GGCDxsou5YbUSzMLUx1y STb2CBE3fHIDB/Pfjhj+TGj8Ip2NToRnuaNy9Xra/z3Jy1G0jnNSQB8kN2XRaCUJYk4F dKCHHlzD+nl1IGUwW0lzcvx1l4bgKTyNpxHxasb7IwYE0q8m72U9a0kMCF/obW+aCCqR motgJsmYvVgEuRDANp2TOypyqnaGLwtNySrBQh+39YxTSI+v2gDKYYEnO/h1UNH1eyE7 iiMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749671855; x=1750276655; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cqMCLZyOkpRAbmSd1eEk7hYlIDeFqlCFB/I/s26FVVE=; b=aMNDnvcKIuPdUyb7XJjqX/4vVmqF90obP0/7OVK7JGDNb97nk4bTq/kwwSFnawwKRw eT6XgZ0sbkfxBzmP+QCTCYwRf7P+LH42hB0PBrO+Zx/sNVRgDEtPzNHo8hrt5wHUIMP3 2rRL/FuowfEvge+O0+BNNeriZzKvbemar4agroty4FX8VAkApMbkgBB0ObjFCxn8EJQj 8hViKAsX1CzxK7ZikRz0Gd8qYCZMJa3SRYsniTe0zOW6xpDRCUHAWXHnQBb0bWjvpX7H AJY3vHWu9gN6IrpLJzMpz2u1uBteOnKUdnavNTdgqAWzLcC821KmUBDHmVUaHVUMQU2S E+4A== X-Gm-Message-State: AOJu0YwbJvrdy/E5chmeg+cAP+Bxev+WbtgIR8cc+0B6F9CRbb+KB6hZ 9ZDATbAO6XrQpcZB9LdYI3uNOyZWVl+jW460o7f7KNWuF2XkAGMDqJ9DFLax0w== X-Gm-Gg: ASbGncuyvyPwDx7GrmVai3CqsGT/krlJNkejehw78nMLcNbYGTs8afK98YIAAbOHg71 SFs4siJ9/8ZhSpIKqRC2MZ06eq5Tojx49OCCn3NuWbwRIB5R2CGO7k5v9hKOvjJaaFZaJVcANu6 brp5okGX/+tKevVwK0AW4sWi+NAIoqFrriFJiK1lmLgsXd/dPuJThvZ6XaSCcOJwawTVTy91vBM 26ApTtXIud8/Z99dtRCJ/prh4Cku60otN0lt53MsPAnopXq3mLM6QskeNh+3uQ3PApVcFxtaTjz DLC2JXgA5ZJVVXOwZWdMnno3K5OWwqpJgzpyLNlnY1bMd2d7nsauF5bsavfs8g44RhY2VxernMv DAT6Mkw5EkkZrYFBcDzE88uNZHBVj5kL/bc8oFaPBok8vJrL2/svhnVhK++xiJ24C/xh7S59MkR i7pD/s/g== X-Google-Smtp-Source: AGHT+IFr9tdy4wbCnGQRNSs8fSqjVyJOdM/xCHQ2FjkCjZUhtM3Tm5enUgqvuQO05ujnTHPxOOSsoA== X-Received: by 2002:a05:6000:2385:b0:3a3:6b07:20a1 with SMTP id ffacd0b85a97d-3a5607473c4mr593363f8f.40.1749671855418; Wed, 11 Jun 2025 12:57:35 -0700 (PDT) Received: from localhost.localdomain (p200301023700450060f2a9d7350ce887.dip0.t-ipconnect.de. [2003:102:3700:4500:60f2:a9d7:350c:e887]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244f04dsm16232467f8f.73.2025.06.11.12.57.33 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Jun 2025 12:57:33 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 Jun 2025 21:57:22 +0200 Message-Id: <20250611195725.95154-1-epirat07@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: With the previous logic, the integer writing codepath was unreachable. Fix CID 1646948 --- fftools/textformat/tf_mermaid.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index d3b9131ada..59b11811f1 100644 --- a/fftools/textformat/tf_mermaid.c +++ b/fftools/textformat/tf_mermaid.c @@ -604,22 +604,20 @@ static void mermaid_print_value(AVTextFormatContext *tfc, const char *key, break; case AV_DIAGRAMTYPE_ENTITYRELATIONSHIP: - - if (!is_int && str) { - const char *col_type; + const char *col_type = ""; if (key[0] == '_') return; - if (sec_data.section_id && !strcmp(str, sec_data.section_id)) - col_type = "PK"; - else if (sec_data.dest_id && !strcmp(str, sec_data.dest_id)) - col_type = "FK"; - else if (sec_data.src_id && !strcmp(str, sec_data.src_id)) - col_type = "FK"; - else - col_type = ""; + if (str) { + if (sec_data.section_id && !strcmp(str, sec_data.section_id)) + col_type = "PK"; + else if (sec_data.dest_id && !strcmp(str, sec_data.dest_id)) + col_type = "FK"; + else if (sec_data.src_id && !strcmp(str, sec_data.src_id)) + col_type = "FK"; + } MM_INDENT(); -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".