[FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid

[Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>]

With the previous logic, the integer writing codepath was unreachable.

Fix CID 1646948
---
 fftools/textformat/tf_mermaid.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c
index d3b9131ada..59b11811f1 100644
--- a/fftools/textformat/tf_mermaid.c
+++ b/fftools/textformat/tf_mermaid.c
@@ -604,22 +604,20 @@ static void mermaid_print_value(AVTextFormatContext *tfc, const char *key,
 
             break;
         case AV_DIAGRAMTYPE_ENTITYRELATIONSHIP:
-
-            if (!is_int && str)
             {
-                const char *col_type;
+                const char *col_type = "";
 
                 if (key[0] == '_')
                     return;
 
-                if (sec_data.section_id && !strcmp(str, sec_data.section_id))
-                    col_type = "PK";
-                else if (sec_data.dest_id && !strcmp(str, sec_data.dest_id))
-                    col_type = "FK";
-                else if (sec_data.src_id && !strcmp(str, sec_data.src_id))
-                    col_type = "FK";
-                else
-                    col_type = "";
+                if (str) {
+                    if (sec_data.section_id && !strcmp(str, sec_data.section_id))
+                        col_type = "PK";
+                    else if (sec_data.dest_id && !strcmp(str, sec_data.dest_id))
+                        col_type = "FK";
+                    else if (sec_data.src_id && !strcmp(str, sec_data.src_id))
+                        col_type = "FK";
+                }
 
                 MM_INDENT();
 
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".