From: Niklas Haas <ffmpeg@haasn.xyz> To: ffmpeg-devel@ffmpeg.org Cc: Niklas Haas <git@haasn.dev> Subject: [FFmpeg-devel] [PATCH v6 18/18] swscale/graph: allow experimental use of new format handler Date: Wed, 11 Jun 2025 14:47:24 +0200 Message-ID: <20250611124805.73196-19-ffmpeg@haasn.xyz> (raw) In-Reply-To: <20250611124805.73196-1-ffmpeg@haasn.xyz> From: Niklas Haas <git@haasn.dev> Now, make it a Killer-Feature! --- libswscale/graph.c | 84 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/libswscale/graph.c b/libswscale/graph.c index 2b26c068d1..ff3977c9a6 100644 --- a/libswscale/graph.c +++ b/libswscale/graph.c @@ -34,6 +34,7 @@ #include "lut3d.h" #include "swscale_internal.h" #include "graph.h" +#include "ops.h" static int pass_alloc_output(SwsPass *pass) { @@ -455,6 +456,85 @@ static int add_legacy_sws_pass(SwsGraph *graph, SwsFormat src, SwsFormat dst, return 0; } +/********************* + * Format conversion * + *********************/ + +static int add_convert_pass(SwsGraph *graph, SwsFormat src, SwsFormat dst, + SwsPass *input, SwsPass **output) +{ + const SwsPixelType type = SWS_PIXEL_F32; + + SwsContext *ctx = graph->ctx; + SwsOpList *ops = NULL; + int ret = AVERROR(ENOTSUP); + + /* Mark the entire new ops infrastructure as experimental for now */ + if (!(ctx->flags & SWS_UNSTABLE)) + goto fail; + + /* The new format conversion layer cannot scale for now */ + if (src.width != dst.width || src.height != dst.height || + src.desc->log2_chroma_h || src.desc->log2_chroma_w || + dst.desc->log2_chroma_h || dst.desc->log2_chroma_w) + goto fail; + + /* The new code does not yet support alpha blending */ + if (src.desc->flags & AV_PIX_FMT_FLAG_ALPHA && + ctx->alpha_blend != SWS_ALPHA_BLEND_NONE) + goto fail; + + ops = ff_sws_op_list_alloc(); + if (!ops) + return AVERROR(ENOMEM); + ops->src = src; + ops->dst = dst; + + ret = ff_sws_decode_pixfmt(ops, src.format); + if (ret < 0) + goto fail; + ret = ff_sws_decode_colors(ctx, type, ops, src, &graph->incomplete); + if (ret < 0) + goto fail; + ret = ff_sws_encode_colors(ctx, type, ops, dst, &graph->incomplete); + if (ret < 0) + goto fail; + ret = ff_sws_encode_pixfmt(ops, dst.format); + if (ret < 0) + goto fail; + + av_log(ctx, AV_LOG_VERBOSE, "Conversion pass for %s -> %s:\n", + av_get_pix_fmt_name(src.format), av_get_pix_fmt_name(dst.format)); + + av_log(ctx, AV_LOG_DEBUG, "Unoptimized operation list:\n"); + ff_sws_op_list_print(ctx, AV_LOG_DEBUG, ops); + av_log(ctx, AV_LOG_DEBUG, "Optimized operation list:\n"); + + ff_sws_op_list_optimize(ops); + if (ops->num_ops == 0) { + av_log(ctx, AV_LOG_VERBOSE, " optimized into memcpy\n"); + ff_sws_op_list_free(&ops); + *output = input; + return 0; + } + + ff_sws_op_list_print(ctx, AV_LOG_VERBOSE, ops); + + ret = ff_sws_compile_pass(graph, ops, 0, dst, input, output); + if (ret < 0) + goto fail; + + ret = 0; + /* fall through */ + +fail: + ff_sws_op_list_free(&ops); + if (ret == AVERROR(ENOTSUP)) + return add_legacy_sws_pass(graph, src, dst, input, output); + return ret; +} + + /************************** * Gamut and tone mapping * **************************/ @@ -524,7 +604,7 @@ static int adapt_colors(SwsGraph *graph, SwsFormat src, SwsFormat dst, if (fmt_in != src.format) { SwsFormat tmp = src; tmp.format = fmt_in; - ret = add_legacy_sws_pass(graph, src, tmp, input, &input); + ret = add_convert_pass(graph, src, tmp, input, &input); if (ret < 0) return ret; } @@ -566,7 +646,7 @@ static int init_passes(SwsGraph *graph) src.color = dst.color; if (!ff_fmt_equal(&src, &dst)) { - ret = add_legacy_sws_pass(graph, src, dst, pass, &pass); + ret = add_convert_pass(graph, src, dst, pass, &pass); if (ret < 0) return ret; } -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-11 12:50 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-06-11 12:47 [FFmpeg-devel] [PATCH v6 00/18] swscale: new ops framework Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 01/18] swscale/graph: pass per-pass image pointers to setup() Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 02/18] swscale/format: rename legacy format conversion table Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 03/18] swscale/format: add ff_fmt_clear() Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 04/18] tests/checkasm: increase number of runs in between measurements Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 05/18] tests/checkasm: generalize DEF_CHECKASM_CHECK_FUNC to floats Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 06/18] swscale: add SWS_UNSTABLE flag Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 07/18] swscale/ops: introduce new low level framework Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 08/18] swscale/optimizer: add high-level ops optimizer Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 09/18] swscale/ops_internal: add internal ops backend API Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 10/18] swscale/ops: add dispatch layer Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 11/18] swscale/optimizer: add packed shuffle solver Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 12/18] swscale/ops_chain: add internal abstraction for kernel linking Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 13/18] swscale/ops_backend: add reference backend basend on C templates Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 14/18] swscale/ops_memcpy: add 'memcpy' backend for plane->plane copies Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 15/18] swscale/x86: add SIMD backend Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 16/18] tests/checkasm: add checkasm tests for swscale ops Niklas Haas 2025-06-11 12:47 ` [FFmpeg-devel] [PATCH v6 17/18] swscale/format: add new format decode/encode logic Niklas Haas 2025-06-11 12:47 ` Niklas Haas [this message] 2025-06-11 17:59 ` [FFmpeg-devel] [PATCH v6 00/18] swscale: new ops framework Niklas Haas 2025-06-16 12:31 ` Niklas Haas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250611124805.73196-19-ffmpeg@haasn.xyz \ --to=ffmpeg@haasn.xyz \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=git@haasn.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git