From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 991DA4E310 for ; Tue, 10 Jun 2025 00:07:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6981568CB32; Tue, 10 Jun 2025 03:07:21 +0300 (EEST) Received: from relay.b.hostedemail.com (smtprelay0039.b.hostedemail.com [64.98.42.39]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 24D4068C5A8 for ; Tue, 10 Jun 2025 03:07:14 +0300 (EEST) Received: from omf01.b.hostedemail.com (omf01 [10.200.6.64]) by unirelay03.b.hostedemail.com (Postfix) with ESMTP id EF6736052B for ; Tue, 10 Jun 2025 00:07:11 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: ff@hawaiiantel.net) by omf01.b.hostedemail.com (Postfix) with ESMTPA id 89100160002 for ; Tue, 10 Jun 2025 00:07:10 +0000 (UTC) Date: Mon, 9 Jun 2025 14:07:07 -1000 From: compn To: ffmpeg-devel@ffmpeg.org Message-ID: <20250609140707.00002838@hawaiiantel.net> In-Reply-To: References: <653c199c57434b5041cbaa34fe7c26f206a4bc90.1749463495.git.pross@xvid.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 X-Stat-Signature: q43bcsxc8hbeegsq744me6a4ta6pug1i X-Rspamd-Server: rspamout02 X-Spam-Status: No, score=0.10 X-Rspamd-Queue-Id: 89100160002 X-Session-Marker: 666640686177616969616E74656C2E6E6574 X-Session-ID: U2FsdGVkX18g8RZuIviti8UUPayhHUJ+Hdcp45gdr+g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hawaiiantel.net; h=date:from:to:subject:message-id:in-reply-to:references:mime-version:content-type:content-transfer-encoding; s=opensrs-2024012500; bh=jDcWodLLpbF977EJCjbPUDe7gikCOosW3vRLPkuhqPM=; b=G4er9gd8LTnZgv2wuVxJfNaV8O5EMDtWlHWYAtfIesIUcTkn8e5tw7i4DfEahs2Tb934qzoMVi8jQ2wT6z+Q1OW3CF93KKpugdz8lZ8syHG8EUvPxj9pYXBbanxq8AODTa/q+qqkjHZtMi/5Mb21a9ORukc3QWZQiRfyZPURdHg4IfDJ+3uAXR/swrtD1mExrFsD78u+eGom2Mj2KFRuk3LUiic27E0NNYmP2a2vavt/RmQC6GVwZ98dSxb251CLfXFpv/4rJd7z12JVm4bPBd5j/giFC6WWW46StIiF/j+C2dLn4NToCMghxKyHJ7rAlNELbZH+R3Wr3X2UYr+jBQ== X-HE-Tag: 1749514030-163741 X-HE-Meta: U2FsdGVkX1+WsQzTWTh2lETZ1zyYBZ4mqrKaDYO6bCz5ctsxjYXo4aVmoVeHlJeJN9kNRC0YGp2RmCQdX0ce2Out9R3OMCGuRTN7BL5BwL+E59WCTFCtLe6fdXAQp8jDPtQ96WxhDIsuO9CbWbHJg7zNJsGxbkUKr3Jy0/s6mk1yKoNbJuBIknxVtc0pE7jRG6qEIYOG7068etn3sE60nGlgtmLg7zsGSObLVhG1BRqqwPcrVqsyVy02M3eHuMbX3AFYCoahINJVuPZYe4izDJsvbYfqchY43IEYzRJP6YqlPubAbGex4rAfneWSTjvj1fkyaTyViqhYzteOd9Erenp9KYIup7KXnWeehhIsq/7L7nnSXFWBxNBf5YxdKa3fjIkfU3HdALfQIwgFMRTXO8t6D2vFZv4kYAlqHuPAH0z14ecZo419fblTl/XoHs9erycXj75//jr6K3ywmWwXgFHMXFO/lhCk Subject: Re: [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 10 Jun 2025 00:25:24 +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavformat/aiff.c | 1 + > > libavformat/aiffdec.c | 3 +++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/libavformat/aiff.c b/libavformat/aiff.c > > index 1ceac69a70..907f7d8d28 100644 > > --- a/libavformat/aiff.c > > +++ b/libavformat/aiff.c > > @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] = { > > { AV_CODEC_ID_GSM, MKTAG('G','S','M',' ') }, > > { AV_CODEC_ID_ADPCM_G722, MKTAG('G','7','2','2') }, > > { AV_CODEC_ID_ADPCM_G726LE, MKTAG('G','7','2','6') }, > > + { AV_CODEC_ID_G728, MKTAG('G','7','2','8') }, > > { AV_CODEC_ID_PCM_S16BE, MKTAG('t','w','o','s') }, > > { AV_CODEC_ID_PCM_S16LE, MKTAG('s','o','w','t') }, > > { AV_CODEC_ID_ADPCM_IMA_QT, MKTAG('i','m','a','4') }, > > diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c > > index bd5bd2e4bb..aeb00cccd0 100644 > > --- a/libavformat/aiffdec.c > > +++ b/libavformat/aiffdec.c > > @@ -174,6 +174,9 @@ static int get_aiff_header(AVFormatContext *s, int64_t size, > > case AV_CODEC_ID_GSM: > > par->block_align = 33; > > break; > > + case AV_CODEC_ID_G728: > > + par->block_align = 5; > > + break; > > default: > > aiff->block_duration = 1; > > break; > > > Is this and the riff patch based on some spec or are you just inventing > things here? maybe i can help. https://wiki.multimedia.cx/index.php/G.728 lists 0xCD02 and 0x0041 according to the history of that wiki page, the 0xCD02 comes from "plcmg728.acm" binary codec. other list of twocc here: https://wiki.multimedia.cx/index.php/TwoCC i havent myself tested plcmg728.acm , but its on my list to investigate here https://wiki.multimedia.cx/index.php/Category_talk:Audio_Codecs plcmg728.acm should be included with the software: Polycom PVX "Create video conferences with a USB webcam" did Polycom make up that entry or should we support it anyways? i say support it until another 0xCD02 shows up. and then we deal with the conflict at that time. if you go to the spec page https://www-mmsp.ece.mcgill.ca/Documents/AudioFormats/AIFF/AIFF.html and click samples https://www-mmsp.ece.mcgill.ca/Documents/AudioFormats/AIFF/Samples.html at the bottom is g728 sample o2_728.aiff (1 kB) * AIFF-C file: G.728 data (compression code: G728) hopefully that answers all riff/aiff questions. -compn _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".