From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9FA2B4E262 for ; Sat, 7 Jun 2025 23:29:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id F3CF368BF94; Sun, 8 Jun 2025 02:29:13 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E74C268A112 for ; Sun, 8 Jun 2025 02:29:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4F9F841DF4 for ; Sat, 7 Jun 2025 23:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1749338946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oMhUxg9Mf197fKg50IwFgznnUvAuciBeHy3UkUbfjT4=; b=kCNpMp+jH1IaJXww+M1TsVE3n0xwc5sRqJUasEq3z92rUTopjaXsaQdGOCA0Q0XK96Bem9 QT7qkJprYvlzcIYN3h+GVss1aIWRdTKIgoN9n59VdNwGLG7FXyhW1RRyAu48H+wzs/8l0y GGXpNZfD2es9Hl7LtdM3BycMyYV6k1NOkV2EBqByoxpvvjFUu5L+jxA+/B5KZmwxLfiBdB ZK1m7vasKiV3QYp/07RXD1rU7Lom52/MFg2+TMT/SM0rzHvfU2fOIAADuIriF6g9ye0KhE J01TQOjIV916cvsqVa5VYqIJzayWNi2sIbCn+XO/Ffdq3vU3cxkm6BTEQqEkiw== Date: Sun, 8 Jun 2025 01:29:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250607232905.GK29660@pb2> References: <20250531133215.64025-1-michael@niedermayer.cc> <20250604010512.GN29660@pb2> MIME-Version: 1.0 In-Reply-To: <20250604010512.GN29660@pb2> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdejudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3349459777700917702==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3349459777700917702== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jeOSGSU84GMo1gVd" Content-Disposition: inline --jeOSGSU84GMo1gVd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote: [...] > > > #define FFSWAP(type,a,b) do{type SWAP_tmp=3D b; b=3D a; a=3D SWAP_tm= p;}while(0) > >=20 > > 1. I don't like that you change the common case (namely the integer one) > > and thereby making the name longer (and making this patch huge). >=20 > I can just rename FFMINI/MAXI to FFMIN/MAX if preferred are there any objections to FFMIND / FFMINF / FFMAXD / FFMAXF ? if not i intend to apply these in the next days (unless i forget) >=20 >=20 > > 2. This is supposed to be used to provide optimized platform-specific > > floating-point min and max functions. How is this supposed to be done > > with your approach? Would macros.h get internal plattform-specific > > headers like intreadwrite.h that are only included when building FFmpeg > > to override the ordinary macros? >=20 > I just intended to do the work that noone else wanted to do, > which was replacing the macros with type specific ones. >=20 > These can then be moved to whatever is the best place when optimizations > are introduced or replaced by a static inline function where thats possib= le thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus --jeOSGSU84GMo1gVd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaETLQQAKCRBhHseHBAsP q38IAJoDpWPAN23tdxyRfFrQoVNGfuRL1gCeM+9B7yvF479U9viB0KdLHbQrpH0= =+0gL -----END PGP SIGNATURE----- --jeOSGSU84GMo1gVd-- --===============3349459777700917702== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3349459777700917702==--