From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 970BC4E203 for ; Sat, 7 Jun 2025 17:39:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B0DA968C11C; Sat, 7 Jun 2025 20:39:01 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 094C068C037 for ; Sat, 7 Jun 2025 20:38:54 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E67841C7B for ; Sat, 7 Jun 2025 17:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1749317934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ItqsEhwyN1vGWRqojkuKC/Bzn9JZUiLSBap8VekMdo=; b=Dg6IGtT+o4donlsfz9+JPEiJCJF4fBbhNc4K751AR1xJhIYAMI1q8buUg0ZpuclI/d6JDF JN6l6SHdtiUnfyw36BQTIfqSog8kIilXyqVXnD2Zk1xjjn+q7UQObnfPYIyhB5mpgO9kJt lmPpR+lC2lRDtcY6QP+Jw7MwyLeYLt7kPYug/cnmi4EW5n8ToIATPXUsO1mgccjSnWj9ij daSMXIs2kX0mPY+D6G1XPknOfYiHkQCfrFx+7eVNjuk5hzaYeXuzx4R8Ks5P1eAZUjBrC9 xUKNxBuquSpRzBtXpidaAQtUc61GJj6BAV3UjAh+EbsyQf1LB9IjYZ33qI+Y8w== Date: Sat, 7 Jun 2025 19:38:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250607173853.GH29660@pb2> References: <20250606231220.88037-1-michael@niedermayer.cc> <0b9b3229-e3e7-46c3-9348-93415aae1a78@gmail.com> MIME-Version: 1.0 In-Reply-To: <0b9b3229-e3e7-46c3-9348-93415aae1a78@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeikeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8554024863865649242==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8554024863865649242== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LEAcQ+GJVjFvjt8t" Content-Disposition: inline --LEAcQ+GJVjFvjt8t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 07, 2025 at 05:23:26PM +0100, Derek Buitenhuis wrote: > On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > > as FFMIN() is a macro and avio_size() is thus evaluated multiple > > times > >=20 > > CC: Justin Ruggles > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/dhav.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > LGTM. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --LEAcQ+GJVjFvjt8t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaER5JgAKCRBhHseHBAsP q0hWAKCb/3Uu6KF3+/WxxB03viHkdn2pvQCdEeelXBoBRSkgo+s8HA3R0zRkmz8= =lrXR -----END PGP SIGNATURE----- --LEAcQ+GJVjFvjt8t-- --===============8554024863865649242== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8554024863865649242==--