From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BB1964C194 for ; Fri, 6 Jun 2025 13:25:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5AB7D68C85C; Fri, 6 Jun 2025 16:25:13 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3211868B9C6 for ; Fri, 6 Jun 2025 16:25:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 704E944201 for ; Fri, 6 Jun 2025 13:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1749216306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YVgp54tjZ07o7JqfgtmVcTxFQ1H7hponPFSbsE9l4XA=; b=SaRy680CgcdZYUwQlfNeK5l8cBqxnw8aCryNhLzW6Y5+RsCTv5a2TQJNSIDm7MOfXWuXig g+V4sLoWyX3u5YWlhyNM7YJxjfo4SKh57dADMIs/koiTfWnznMDudrIEM4xaIIIo1qH1R3 YDaWJJwxp2N0W7F4xkJiQ7sQWuOfQ7uGr+Nzr38/oaWyFvwfVyY8H++956le//TFK6RF1e UvsZdcpQZKV4WhwDJDcC5579TJMadjtBYpn39kGS6WxgXEQGIeqQCipw23fuCN52E7C/mh 6JDMDzqnaLwPD8mQnV4IcQObKqtr33gWQDQIXhpXaQ8ZToe+JyW+lwDO3f16WA== Date: Fri, 6 Jun 2025 15:25:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250606132505.GY29660@pb2> References: <20250606005104.1798801-1-michael@niedermayer.cc> <20250606023545.GW29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdehudehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffheevhfdvvdfhtdfgtefhtdeuleeftdevkeffleejtefhgedthfefgffgueeftdenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Add bitexact for fate-mov-mp4-frag-flush X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8833140776424961961==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8833140776424961961== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BzEiJqAgB6DMYWwG" Content-Disposition: inline --BzEiJqAgB6DMYWwG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 06, 2025 at 12:52:33PM +0800, Zhao Zhili wrote: >=20 >=20 > > On Jun 6, 2025, at 10:35, Michael Niedermayer = wrote: > >=20 > > On Fri, Jun 06, 2025 at 03:40:33AM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Signed-off-by: Michael Niedermayer > >>> --- > >>> tests/fate/mov.mak | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>=20 > >>> diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak > >>> index b966249dc07..117d6581e9b 100644 > >>> --- a/tests/fate/mov.mak > >>> +++ b/tests/fate/mov.mak > >>> @@ -84,9 +84,9 @@ fate-mov-ibi-elst-starts-b: CMD =3D framemd5 -flags= +bitexact -i $(TARGET_SAMPLES) > >>> # Makes sure that we handle overlapping framgments > >>> fate-mov-frag-overlap: CMD =3D framemd5 -i $(TARGET_SAMPLES)/mov/frag= _overlap.mp4 > >>>=20 > >>> -fate-mov-mp4-frag-flush: CMD =3D md5 -f lavfi -i color=3Dblue,format= =3Drgb24,trim=3Dduration=3D0.04 -f lavfi -i anullsrc,aformat=3Ds16,atrim=3D= duration=3D2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmente= d -frag_duration 1000000 -frag_interleave 1 -f mp4 > >>> +fate-mov-mp4-frag-flush: CMD =3D md5 -f lavfi -i color=3Dblue,format= =3Drgb24,trim=3Dduration=3D0.04 -f lavfi -i anullsrc,aformat=3Ds16,atrim=3D= duration=3D2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmente= d -frag_duration 1000000 -frag_interleave 1 -flags +bitexact -f mp4 > >>> fate-mov-mp4-frag-flush: CMP =3D oneline > >>> -fate-mov-mp4-frag-flush: REF =3D a10c0e2e2dfc120f31ca5e59e0e4392a > >>> +fate-mov-mp4-frag-flush: REF =3D b77ccd79e5455c6b7830e76fedf168f7 > >>> FATE_MOV_FFMPEG-$(call ALLYES, LAVFI_INDEV COLOR_FILTER FORMAT_FILTER= TRIM_FILTER \ > >>> ANULLSRC_FILTER AFORMAT_FILTER ATRIM_F= ILTER \ > >>> WRAPPED_AVFRAME_DECODER PCM_S16LE_DECO= DER PCM_S16BE_DECODER \ > >>=20 > >> This removes the lavc version from the stream-level "encoder" tag, yet > >> the lavf version is still kept in the format metadata. Use -bitexact to > >> disable both (or -flags +bitexact -fflags +bitexact). > >=20 > > ok, will apply this tomorrow: > > @@ -84,9 +84,9 @@ fate-mov-ibi-elst-starts-b: CMD =3D framemd5 -flags += bitexact -i $(TARGET_SAMPLES) > > # Makes sure that we handle overlapping framgments > > fate-mov-frag-overlap: CMD =3D framemd5 -i $(TARGET_SAMPLES)/mov/frag_o= verlap.mp4 > >=20 > > -fate-mov-mp4-frag-flush: CMD =3D md5 -f lavfi -i color=3Dblue,format= =3Drgb24,trim=3Dduration=3D0.04 -f lavfi -i anullsrc,aformat=3Ds16,atrim=3D= duration=3D2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmente= d -frag_duration 1000000 -frag_interleave 1 -f mp4 > > +fate-mov-mp4-frag-flush: CMD =3D md5 -f lavfi -i color=3Dblue,format= =3Drgb24,trim=3Dduration=3D0.04 -f lavfi -i anullsrc,aformat=3Ds16,atrim=3D= duration=3D2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmente= d -frag_duration 1000000 -frag_interleave 1 -bitexact -f mp4 > > fate-mov-mp4-frag-flush: CMP =3D oneline > > -fate-mov-mp4-frag-flush: REF =3D a10c0e2e2dfc120f31ca5e59e0e4392a > > +fate-mov-mp4-frag-flush: REF =3D c9d0236bde4a0b24a01f6a032fd72e04 > > FATE_MOV_FFMPEG-$(call ALLYES, LAVFI_INDEV COLOR_FILTER FORMAT_FILTER T= RIM_FILTER \ > > ANULLSRC_FILTER AFORMAT_FILTER ATRIM_FIL= TER \ > > WRAPPED_AVFRAME_DECODER PCM_S16LE_DECODE= R PCM_S16BE_DECODER \ >=20 > Thanks for the fix. >=20 > It=E2=80=99s easy to miss this or that with FATE, can we have a test for = test, and recursively until the final reliable test :P running fate with random offset added to versions could be done but it would trigger full rebuild maybe we could add bitexact in a more automated way in fate so its harder t= o forget about the dependancies theres --enable-random and also a test on fate.ffmpe= g.org with it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB For a strong democracy, genuine criticism is necessary, allegations benefit noone, they just cause unnecessary conflicts. - Narendra Modi --BzEiJqAgB6DMYWwG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaELsLgAKCRBhHseHBAsP q4J4AKCV9EMGJhcDeq4bjNfo39c8Det+4QCeMb9gW4e0GWggKOaR1GaYPrHO0zY= =UHbv -----END PGP SIGNATURE----- --BzEiJqAgB6DMYWwG-- --===============8833140776424961961== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8833140776424961961==--