Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1798 bytes --]

On Fri, Jun 06, 2025 at 12:06:34AM +0800, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> ---
>  libavformat/avformat.h | 3 +--
>  libavformat/format.c   | 2 ++
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 2034d2aecc..6edcf11022 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -470,8 +470,7 @@ typedef struct AVProbeData {
>  /**
>   * The muxer/demuxer is experimental and should be used with caution.
>   *
> - * - demuxers: will not be selected automatically by probing, must be specified
> - *             explicitly.
> + * Will not be selected automatically, must be specified explicitly.
>   */
>  #define AVFMT_EXPERIMENTAL  0x0004
>  #define AVFMT_SHOW_IDS      0x0008 /**< Show format stream IDs numbers. */
> diff --git a/libavformat/format.c b/libavformat/format.c
> index 71018ea6ab..516925e7e4 100644
> --- a/libavformat/format.c
> +++ b/libavformat/format.c
> @@ -95,6 +95,8 @@ const AVOutputFormat *av_guess_format(const char *short_name, const char *filena
>      /* Find the proper file type. */
>      score_max = 0;
>      while ((fmt = av_muxer_iterate(&i))) {
> +        if (fmt->flags & AVFMT_EXPERIMENTAL && !short_name)
> +            continue;

what does AVFMT_EXPERIMENTAL mean for a muxer ?

* a muxer could generate invalid, non compliant data
* a muxer could be insecure and exploitable
* a muxer could lack some feature (iam sure most muxers in most projects lack some feature)

I think the first 2 are reasons to use this flag

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".