From: Steven Liu <lq@chinaffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Steven Liu <lq@chinaffmpeg.org> Subject: [FFmpeg-devel] [PATCH 2/2] avformat/whip: check the exchange sdp url is start with http Date: Fri, 6 Jun 2025 11:02:06 +0800 Message-ID: <20250606030206.67340-2-lq@chinaffmpeg.org> (raw) In-Reply-To: <20250606030206.67340-1-lq@chinaffmpeg.org> Make sure the WHIP protocol performs the SDP offer/answer exchange with the WebRTC peer over HTTP. Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavformat/whip.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c index ce06a66bc4..b78ad27858 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -732,10 +732,18 @@ static int exchange_sdp(AVFormatContext *s) URLContext *whip_uc = NULL; AVDictionary *opts = NULL; char *hex_data = NULL; + const char *proto_name = avio_find_protocol_name(s->url); /* To prevent a crash during cleanup, always initialize it. */ av_bprint_init(&bp, 1, MAX_SDP_SIZE); + if (!av_strstart(proto_name, "http", NULL)) { + av_log(whip, AV_LOG_ERROR, "WHIP: Protocol %s is not supported by RTC, choose http, url is %s\n", + proto_name, s->url); + ret = AVERROR(EINVAL); + goto end; + } + if (!whip->sdp_offer || !strlen(whip->sdp_offer)) { av_log(whip, AV_LOG_ERROR, "WHIP: No offer to exchange\n"); ret = AVERROR(EINVAL); -- 2.39.3 (Apple Git-146) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-06 3:09 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-06-06 3:02 [FFmpeg-devel] [PATCH 1/2] avformat/whip: Remove unnecessary pkt checks Steven Liu 2025-06-06 3:02 ` Steven Liu [this message] 2025-06-09 3:21 ` [FFmpeg-devel] [PATCH 2/2] avformat/whip: check the exchange sdp url is start with http Jack Lau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250606030206.67340-2-lq@chinaffmpeg.org \ --to=lq@chinaffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git