From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B16B74DB76 for ; Wed, 4 Jun 2025 01:11:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8F51468C916; Wed, 4 Jun 2025 04:11:42 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3EC0968C7E7 for ; Wed, 4 Jun 2025 04:11:36 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 861CA439F9 for ; Wed, 4 Jun 2025 01:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1748999495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TY6pr7O75qAgctKMXSNGN/SWbX6yUCmgXk/lr6fWQ/o=; b=pC1NHLLAUktTvOU8exQdx/vMcFyoIq9Ygy9yDIdI9wKc0PDsXhBb9Oa9UTDgQBCoLOkHbP Dn/e0bzcwg0M496mTTMsM+fR7eQGE1MGzeyGs2xzwN6l2dHKV8rM8KSL9u4utXetY3yIWw bAbtWPwycBBhCaMpXW4lOecJucm1xOXqzbtZ8ANfxAT0WA5l5Bh7ny4JVOxazO7sVbtz3M gczi+7wmTQ7jZGCd9F7fnL5uxlYtFsOwG7tu+5T2eNUst4Pg1D7C4EpW/QVxo6SLCBKlGW YpCzVDPl3It9qBpOvk/mErVPGj5msnAU9gNHLqoMN1WgproX5ZhHsIhsJtLUWw== Date: Wed, 4 Jun 2025 03:11:34 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250604011134.GO29660@pb2> References: <101aecd0-2b82-4a20-8742-6824db01551f@gyani.pro> <20250601221323.GZ29660@pb2> <31D036DC-5BEF-4E40-AFF3-7142ADD0BD14@gmail.com> MIME-Version: 1.0 In-Reply-To: <31D036DC-5BEF-4E40-AFF3-7142ADD0BD14@gmail.com> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddufeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeelkeeggfffiedufeejueffjeduhedttdduledtheevveevtdeiueelhfdtuedtkeenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add vf_yazf filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3265215124827414660==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3265215124827414660== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UjBYcXYlxY1UgKxz" Content-Disposition: inline --UjBYcXYlxY1UgKxz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 02, 2025 at 11:25:43AM +0200, Quentin RENARD wrote: > > If this filter is meant to be same as existing zoompan but more precise= ,=C2=A0 > > then you should modify the original filter with a mode option for FP us= e. >=20 > Thing is I hesitated modifying the existing zoompan but there are a few t= hings that don=E2=80=99t fit my use case and I didn=E2=80=99t want to updat= e too many things: >=20 > - frame=E2=80=99s PTS is rewritten > - configurable output size is not dynamic (and is not evaluated in frame = mode) > - if output aspect ratio is different than input aspect ratio, output ima= ge will be stretched >=20 > I can: >=20 > - add an option to enable PTS passthrough > - add =E2=80=9Cw=E2=80=9D and =E2=80=9Ch=E2=80=9D options on top of =E2= =80=9Cs=E2=80=9D options that would allow dynamic output size > - make sure computed crop size respect output aspect ratio >=20 > Would that be ok? >=20 > > I would suggest to add a 2nd FFFilter entry to > > libavfilter/vf_perspective.c > > > > with a zoompan user interface to access the already existing interpolat= ion code > > in vf_perspective.c > > > > we have bilinear and bicubic interpolation there and it should form a > > better basis for the implementation >=20 > Reusing vf_perspective.c interpolation implementations seems like a reall= y great idea, I didn=E2=80=99t know they existed. >=20 > However I don=E2=80=99t understand the way you suggest I should do it. >=20 > Are you suggesting I should add =E2=80=9Cconst FFFilter ff_vf_yazp =3D {}= =E2=80=9D in =E2=80=9Cvf_perspective.c=E2=80=9D and move the zoompan logic = there? If not, maybe what you=E2=80=99re suggesting has already been implem= ented in another filter and I can use it as an example to understand and re= produce it better? I guess whats best would be to factor the interpolation code out of vf_perspective.c into a new file as patch #1 and then use that new factored out code in a new filter that has a zoompan style user interface in patch #2 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --UjBYcXYlxY1UgKxz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaD+dRgAKCRBhHseHBAsP q3ZQAJ4jZL8ySQWSluoiCBAin5PyYIvLvQCdFsq5Uz9fSx+3iVgHjRo6RnlburY= =Q3DJ -----END PGP SIGNATURE----- --UjBYcXYlxY1UgKxz-- --===============3265215124827414660== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3265215124827414660==--