Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused includes, fix declaration

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused includes, fix declaration
Date: Mon, 2 Jun 2025 03:28:28 +0200
Message-ID: <20250602012828.GB29660@pb2> (raw)
In-Reply-To: <4d7af186ce9f8a8d3b12cdc2c979ea54320eed96.1748663925.git.ffmpegagent@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1513 bytes --]

Hi softworkz

On Sat, May 31, 2025 at 03:58:44AM +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>  fftools/resources/resman.c |  7 +++----
>  fftools/resources/resman.h | 10 +---------
>  2 files changed, 4 insertions(+), 13 deletions(-)

seems to breaks build

fftools/resources/resman.c:60:8: error: unknown type name ‘AVMutex’
   60 | static AVMutex mutex = AV_MUTEX_INITIALIZER;
      |        ^~~~~~~
fftools/resources/resman.c:60:24: error: ‘AV_MUTEX_INITIALIZER’ undeclared here (not in a function)
   60 | static AVMutex mutex = AV_MUTEX_INITIALIZER;
      |                        ^~~~~~~~~~~~~~~~~~~~
fftools/resources/resman.c: In function ‘get_resman_context’:
fftools/resources/resman.c:123:5: error: implicit declaration of function ‘ff_mutex_lock’ [-Werror=implicit-function-declaration]
  123 |     ff_mutex_lock(&mutex);
      |     ^~~~~~~~~~~~~
fftools/resources/resman.c:138:5: error: implicit declaration of function ‘ff_mutex_unlock’ [-Werror=implicit-function-declaration]
  138 |     ff_mutex_unlock(&mutex);
      |     ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make: *** [ffbuild/common.mak:81: fftools/resources/resman.o] Error 1
make: *** Waiting for unfinished jobs....

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".