Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 932 bytes --]

Hi

On Sat, May 31, 2025 at 07:40:40PM +0200, Marton Balint wrote:
> 
> 
> On Sat, 31 May 2025, Michael Niedermayer wrote:
> 
> > This allows adjusting them to exactly match whatever is fastest on
> > a given CPU for each type.
> 
> Did you use some tool to make this patch, or it was just manual work?
> 
> Can't you use C11 generics to make this somewhat automatic?

IIRC Remi said that he hit ICE with generics


> 
> And if we are introducing something new, do we really want to stick to
> MIN/MAX macros which possibly evaluate their argument multiple times? It was
> always an issue, so I would love to see us moving away from it.

if one wants to change to a static inline function, this patch is
probably a (required) first step

thx
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Some Animals are More Equal Than Others. - George Orwell's book Animal Farm

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".