From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 109C74D6AF for ; Sun, 1 Jun 2025 16:50:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 32E8A68D5D4; Sun, 1 Jun 2025 19:49:49 +0300 (EEST) Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 503C068D56C for ; Sun, 1 Jun 2025 19:49:39 +0300 (EEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2e3e58edab5so1471529fac.3 for ; Sun, 01 Jun 2025 09:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748796578; x=1749401378; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xjMF8HGScfoSxNo6v5AHXMpJnsrj/xBl/E/9upM3zhs=; b=NcDHqmXRvqfWreurReOLmmrLxnHDXqvXwylgxxrAKCzxdeXbFtkaUloQpVC9aiPt+R riTpmTdU1Yttz5I3RzrUN//8FfJ+0w8kdpoFJMsC0Pq5qEMbbhBObP95J0DIaYVVpRw/ F70GuTEjmJLX4sDiMEtygSEkcamcDqSq4rvFUByVK6NXTPu9Qf4roSk8QTf+KZkO+/OL +sSsAH2FMDrK5PQVSSQZry8eEN+wMk388oucsin8U2P8Axj4FwjokkD7Ndgby9VlgRXp IiVCC0fiqt4iAF4K4Y7iaFXz5BEwt8JGuxt6vwl1HnZvg14CSZjIfFZzQmQ8vbVshBJx lorg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748796578; x=1749401378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xjMF8HGScfoSxNo6v5AHXMpJnsrj/xBl/E/9upM3zhs=; b=KynkypFhDUWXBuCKvrBGayPcpR992hQ1bLbUzvTI0Jwi/1D8zAsPJIasQFHIuKrn0D wl1fnh7rqQVUuR9qTYT4kb4YO7cy2hSIuH8kqTu/R/cIEo9qcVXeTfI33kNWwo4NXMEH YWRsQ1jT2fJFk5Q/6p51KV16nh5nkNmtJsbpkRtLOEJR/wCp0hl+MeSrHogEYdQ3JKUD gVWAmxJV8DnKHFJHSGbLnawhUeGmp979z+NXBY6aW/6Jnmb01a0WxzRBKXRm884Xx9N8 iA6BeDCqgHTM24XXv2tILrb7uwOBPw8P8IqKk9pwP/k+3KmyhVg8LFa9LL5y8/sJSlFD UL/A== X-Gm-Message-State: AOJu0Yxhyua+vzS9HwdxzrqvuBvl/cYxg7tM3ys5p8cYSif1ttXkwI2l 9OO60l7JUOQeqHdUT2JVjsv5/X2O1oAVvq5opyU+5t0nMwvUig+OTjmRFPfvjitm X-Gm-Gg: ASbGncs5ZVB66AODrCRX/LMuePA/V+rSM8sg69M51TUM1QVaqOIyuTSlCv962DmwLfq 5TVUDF7Vq/cQQYPpMaxwOify4lGPDDHDb/7RGx/pgQnULAwHvKL80M7aPaZWWU+J7JGRILUvBZZ n5BPrnN05jpvg2dVik26zDZKbWyRluwwQJIY56yVCpg75c8lztzQZH9+o2rZ53quNEGE3s6T+CY wZ1L93betAXinlbhZe55qF8+6sdhZhRAt0y3ZFrRovSFjqPDXPVXIc5lxV/yB3I+64MvQyUiGDE V2Gl7YnAM1PM2Ti9o6Lw5vVfYJW6NUdFW1gG7EhXe/TYTT7A8Xwcj+L/aCwCvX046e5xWTmfWfj TA/TXvPktX1DM0Rz6ez4= X-Google-Smtp-Source: AGHT+IFdpOKAszZ5dfGbEDlE72R32t8Oyf9kKLscfbCCDYPGS3TprHU8TSizNfB9Z/rUnL1S3QvFrw== X-Received: by 2002:a05:6870:9106:b0:2c2:4c92:77f with SMTP id 586e51a60fabf-2e92a478289mr4782761fac.38.1748796577737; Sun, 01 Jun 2025 09:49:37 -0700 (PDT) Received: from mac.lan (ip72-211-125-114.no.no.cox.net. [72.211.125.114]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2e906c13c13sm1467151fac.45.2025.06.01.09.49.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Jun 2025 09:49:37 -0700 (PDT) From: Romain Beauxis To: ffmpeg-devel@ffmpeg.org Date: Sun, 1 Jun 2025 11:49:30 -0500 Message-Id: <20250601164930.72816-5-romain.beauxis@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250601164930.72816-1-romain.beauxis@gmail.com> References: <20250601164930.72816-1-romain.beauxis@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/4] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Romain Beauxis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --- libavformat/oggparseopus.c | 5 +++++ tests/ref/fate/ogg-opus-chained-meta.txt | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/oggparseopus.c b/libavformat/oggparseopus.c index 65b93b4053..ae4ff22c53 100644 --- a/libavformat/oggparseopus.c +++ b/libavformat/oggparseopus.c @@ -154,6 +154,11 @@ static int opus_packet(AVFormatContext *avf, int idx) } if (os->psize > 8 && !memcmp(packet, "OpusTags", 8)) { + ret = ff_vorbis_update_metadata(avf, st, os->buf + os->pstart + 8, + os->psize - 8); + if (ret < 0) + return ret; + priv->need_comments = 0; return 1; } diff --git a/tests/ref/fate/ogg-opus-chained-meta.txt b/tests/ref/fate/ogg-opus-chained-meta.txt index addc41c1eb..aad9b83700 100644 --- a/tests/ref/fate/ogg-opus-chained-meta.txt +++ b/tests/ref/fate/ogg-opus-chained-meta.txt @@ -13,7 +13,8 @@ Stream ID: 0, frame PTS: 3528, metadata: N/A Stream ID: 0, packet PTS: 4488, packet DTS: 4488 Stream ID: 0, frame PTS: 4488, metadata: N/A Stream ID: 0, packet PTS: -312, packet DTS: -312 -Stream ID: 0, frame PTS: -312, metadata: N/A +Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=Second Stream +Stream ID: 0, frame PTS: -312, metadata: encoder=Lavc61.19.100 libopus:title=Second Stream Stream ID: 0, packet PTS: 648, packet DTS: 648 Stream ID: 0, frame PTS: 648, metadata: N/A Stream ID: 0, packet PTS: 1608, packet DTS: 1608 -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".