From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 193724D6AF for ; Sun, 1 Jun 2025 16:49:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5E3EE68CF6A; Sun, 1 Jun 2025 19:49:42 +0300 (EEST) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 330DE68D221 for ; Sun, 1 Jun 2025 19:49:36 +0300 (EEST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-2e541e0b974so2800309fac.1 for ; Sun, 01 Jun 2025 09:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748796574; x=1749401374; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e7YoN6Vmqv5xTW4YmztQCXFeNGAGGxeJL6sqRmcYe7s=; b=NiLXXfbQZAaziWDp0uqyo8hs0VpNVd0cAieZLFn6Vt/p9DVVug9FrNVLuNLv/ChEWn YxuqUaeOATFGdcxCgecDR1b0HXwMwYPtYc73cnCa8UjOlJFxE+DXC6z21B+iozClj0nZ IebWde0XcfUAj6ZSzH5EYt5A6/qgR0FGmPxvIclz8Q3ASJEB4OOxJRRBtqh2klOIvgQ7 oxVCQQsSE7FD/EjHfT4uc57ePyKwQ+5jW1HX2YjSQcc8YlgfQJkIPThQlqT0Pg86FNUm OMc9/AiNgFIx815wN1Bcgg+6s+SxjGJNi7DIffRYtML/hYGFxUHADvpqB/+DfGWv1yag GAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748796574; x=1749401374; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e7YoN6Vmqv5xTW4YmztQCXFeNGAGGxeJL6sqRmcYe7s=; b=afjUaSU9TtV6P7cq2agVOYOccXeqc59PvV4rGEIxZ8PFFp6qHoHwoQ9cdGOkcdmkU9 BYGLtPNrfvS8W7DdaP1dU37nBvX0uqr9//ZkhSjGAnpMSmtOnTMm7nn1j8kXLXUYrTMu T01mt0Cw2blVsK/JRtfC5cHiKV6PfiNZIy8h2SBBcws9HvBPm4IOmsJI7wtXdSuVQ1rB YilOTL2eTk1Zj0qBwKtIoV4Ld2cmhkTF6QVfBaJAY/UbzJ2/TZh3T4VJZHKVPlejsMag p2WC0K2E/Pt/OcT48vtdCXqTW+e8sJVju3gQ0yJHTK+QzDBdi0Pb2Z8rs3i6nkLcG8KE cotQ== X-Gm-Message-State: AOJu0Yz+QpIErEamgIz0iI7dtK882wLM8MXzWB5kuL1PopXqLii57ucb baocCKKH/dEVuFDVIBTReqH+156DLubodTTE7TPhJtyqnvcNNxyGfsENfzNSrYeL X-Gm-Gg: ASbGncuPALJmWh+TIg5ekxdoBCkgYGk2CmudXA26NL0Xi239hHqqC2y6+uGWm0lbEJI oBlZXO6Pz5E+VkrSkZfyX9JMVZGP+hdVerKOv3oBsDQfZvK0THr1uXAzee9V4hEPdvfVYLRsaaa rtah4slXWXT8HfBmnipOLUcw7naSw0igbfflVXGx0K2rt+8DLQ1VKmUUkm6dSKgSA3sztH0xNJf gEJus4Y7tmAXrWnCcdPq53uOnCNhyZVL96jdDxhsvnb2NnDREEV0T5uY5+voDqyL4qzwNRWZTDa TcxUreowLkNiCUptYkcZ99Je9XdPdHL8OlS5A3qOX2oUfi8RW9fBq4jlsH6KCkUMHbCplfbsd03 nE0ese+i2RnYx9iPYw4GSxH4MpGmFHg== X-Google-Smtp-Source: AGHT+IHSiq3fCZ2x/2eemJC/+RjRaxCPv7H9kzv6rYq/nabZvmYlhZgqGRzHrJFu/vxnwuXkhksNiQ== X-Received: by 2002:a05:6871:3311:b0:2e9:b4:954b with SMTP id 586e51a60fabf-2e948cdeb34mr3290981fac.34.1748796574105; Sun, 01 Jun 2025 09:49:34 -0700 (PDT) Received: from mac.lan (ip72-211-125-114.no.no.cox.net. [72.211.125.114]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2e906c13c13sm1467151fac.45.2025.06.01.09.49.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Jun 2025 09:49:33 -0700 (PDT) From: Romain Beauxis To: ffmpeg-devel@ffmpeg.org Date: Sun, 1 Jun 2025 11:49:26 -0500 Message-Id: <20250601164930.72816-1-romain.beauxis@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 0/4] ogg/{vorbis, opus, flac}: Decode metadata from secondary chained streams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Romain Beauxis , dev@lynne.ee Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a redo of a previous patchset. It is pending the review and commit of https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344442.html but I wanted to send right away for early review. After removing ogg header packets from the demuxer, the changes are really nice: * Factor out vorbis metadata update mechanism * Switch oggdec to use AV_PKT_DATA_STRINGS_METADATA for metadata update through extradata since this is the mechanism already implemented. --> At this point, vorbis chained metadata start working! * Use newly factored out function in ogg/flac parser to enable metadata updates. * Use newly factored out function in ogg/opus parser to enable metadata updates. Voila! Romain Beauxis (4): libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism. libavformat/oggdec.c: Use AV_PKT_DATA_STRINGS_METADATA to pass metadata updates. libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata. libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet. libavformat/oggdec.c | 2 +- libavformat/oggdec.h | 14 ++++++++++++ libavformat/oggparseflac.c | 7 ++++++ libavformat/oggparseopus.c | 5 +++++ libavformat/oggparsevorbis.c | 25 +++++++++++++++------- tests/ref/fate/ogg-flac-chained-meta.txt | 3 ++- tests/ref/fate/ogg-opus-chained-meta.txt | 3 ++- tests/ref/fate/ogg-vorbis-chained-meta.txt | 2 +- 8 files changed, 49 insertions(+), 12 deletions(-) -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".