From: Romain Beauxis <romain.beauxis@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Romain Beauxis <romain.beauxis@gmail.com>, dev@lynne.ee Subject: [FFmpeg-devel] [PATCH 0/4] ogg/{vorbis, opus, flac}: Decode metadata from secondary chained streams. Date: Sun, 1 Jun 2025 11:49:26 -0500 Message-ID: <20250601164930.72816-1-romain.beauxis@gmail.com> (raw) This is a redo of a previous patchset. It is pending the review and commit of https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344442.html but I wanted to send right away for early review. After removing ogg header packets from the demuxer, the changes are really nice: * Factor out vorbis metadata update mechanism * Switch oggdec to use AV_PKT_DATA_STRINGS_METADATA for metadata update through extradata since this is the mechanism already implemented. --> At this point, vorbis chained metadata start working! * Use newly factored out function in ogg/flac parser to enable metadata updates. * Use newly factored out function in ogg/opus parser to enable metadata updates. Voila! Romain Beauxis (4): libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism. libavformat/oggdec.c: Use AV_PKT_DATA_STRINGS_METADATA to pass metadata updates. libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata. libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet. libavformat/oggdec.c | 2 +- libavformat/oggdec.h | 14 ++++++++++++ libavformat/oggparseflac.c | 7 ++++++ libavformat/oggparseopus.c | 5 +++++ libavformat/oggparsevorbis.c | 25 +++++++++++++++------- tests/ref/fate/ogg-flac-chained-meta.txt | 3 ++- tests/ref/fate/ogg-opus-chained-meta.txt | 3 ++- tests/ref/fate/ogg-vorbis-chained-meta.txt | 2 +- 8 files changed, 49 insertions(+), 12 deletions(-) -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-06-01 16:49 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-06-01 16:49 Romain Beauxis [this message] 2025-06-01 16:49 ` [FFmpeg-devel] [PATCH 1/4] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis 2025-06-01 16:49 ` [FFmpeg-devel] [PATCH 2/4] libavformat/oggdec.c: Use AV_PKT_DATA_STRINGS_METADATA to pass metadata updates Romain Beauxis 2025-06-01 16:49 ` [FFmpeg-devel] [PATCH 3/4] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis 2025-06-01 16:49 ` [FFmpeg-devel] [PATCH 4/4] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250601164930.72816-1-romain.beauxis@gmail.com \ --to=romain.beauxis@gmail.com \ --cc=dev@lynne.ee \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git