From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B2D944D026 for ; Fri, 30 May 2025 10:34:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2DCA768D988; Fri, 30 May 2025 13:34:35 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C0ED768037F for ; Fri, 30 May 2025 13:34:28 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 1ABDA40FE0 for ; Fri, 30 May 2025 12:34:28 +0200 (CEST) Date: Fri, 30 May 2025 12:34:27 +0200 Message-ID: <20250530123427.GB13533@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: <20250530022312.GH29660@pb2> References: <20250527081242.22892-1-ffmpeg@haasn.xyz> <20250527081242.22892-15-ffmpeg@haasn.xyz> <20250530022312.GH29660@pb2> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v3 14/17] swscale/x86: add SIMD backend X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 30 May 2025 04:23:12 +0200 Michael Niedermayer wrote: > On Tue, May 27, 2025 at 09:55:33AM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > This covers most 8-bit and 16-bit ops, and some 32-bit ops. It also covers all > > floating point operations. While this is not yet 100% coverage, it's good > > enough for the vast majority of formats out there. > > > > Of special note is the packed shuffle fast path, which uses pshufb at vector > > sizes up to AVX512. > > --- > > libswscale/ops.c | 4 + > > libswscale/x86/Makefile | 3 + > > libswscale/x86/ops.c | 722 +++++++++++++++++++++++ > > libswscale/x86/ops_common.asm | 305 ++++++++++ > > libswscale/x86/ops_float.asm | 389 ++++++++++++ > > libswscale/x86/ops_int.asm | 1049 +++++++++++++++++++++++++++++++++ > > 6 files changed, 2472 insertions(+) > > create mode 100644 libswscale/x86/ops.c > > create mode 100644 libswscale/x86/ops_common.asm > > create mode 100644 libswscale/x86/ops_float.asm > > create mode 100644 libswscale/x86/ops_int.asm > > seems to break on x86-32 linux There was no intent to support x86-32 as part of this series. I will fix it by adding the appropriate build condition. > > ... > src/libswscale/x86/ops_float.asm:389: error: symbol `m9' undefined > src/libswscale/x86/ops_float.asm:378: ... from macro `linear_fns' defined here > src/libswscale/x86/ops_float.asm:339: ... from macro `linear_mask' defined here > src/libswscale/x86/ops_float.asm:330: ... from macro `linear_inner' defined here > src/libswscale/x86/ops_common.asm:296: ... from macro `IF' defined here > src//libavutil/x86/x86inc.asm:1639: ... from macro `movdqa' defined here > src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined here > src//libavutil/x86/x86inc.asm:1996: ... from macro `vmovdqa' defined here > src/libswscale/x86/ops_float.asm:389: error: symbol `m10' undefined > src/libswscale/x86/ops_float.asm:378: ... from macro `linear_fns' defined here > src/libswscale/x86/ops_float.asm:339: ... from macro `linear_mask' defined here > src/libswscale/x86/ops_float.asm:331: ... from macro `linear_inner' defined here > src/libswscale/x86/ops_common.asm:296: ... from macro `IF' defined here > src//libavutil/x86/x86inc.asm:1639: ... from macro `movdqa' defined here > src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined here > src//libavutil/x86/x86inc.asm:1996: ... from macro `vmovdqa' defined here > src/libswscale/x86/ops_float.asm:389: error: symbol `m11' undefined > src/libswscale/x86/ops_float.asm:378: ... from macro `linear_fns' defined here > src/libswscale/x86/ops_float.asm:339: ... from macro `linear_mask' defined here > src/libswscale/x86/ops_float.asm:332: ... from macro `linear_inner' defined here > src/libswscale/x86/ops_common.asm:296: ... from macro `IF' defined here > src//libavutil/x86/x86inc.asm:1639: ... from macro `movdqa' defined here > src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined here > src//libavutil/x86/x86inc.asm:1996: ... from macro `vmovdqa' defined here > make: *** [src/ffbuild/common.mak:103: libswscale/x86/ops_float.o] Error 1 > > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Old school: Use the lowest level language in which you can solve the problem > conveniently. > New school: Use the highest level language in which the latest supercomputer > can solve the problem without the user falling asleep waiting. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".