From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 793374CD77 for <ffmpegdev@gitmailbox.com>; Wed, 28 May 2025 14:32:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id F237268D797; Wed, 28 May 2025 17:32:21 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B26CA68D766 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 May 2025 17:32:15 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a376ba6f08so2962925f8f.1 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 May 2025 07:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748442735; x=1749047535; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xr3uS+DPgmCd+/z5aHNgeEzHhg/oAbMGgRViE5pk8dY=; b=aeekwX6TUik6OJwc/Sq8rzN6lwp9RNRisNsNVihp894kSaQCFgzcnKQ1tPuDJYckUU 6KPX52GiaN/WBdbhG7IFjpCHxxPUGhpbZKXVjS4jBttveqgaQ3QmRLHd+EbZzX8xn9XO 41TD5CXLJOT3+YK5EeYy6ZWt51S0x8lalV7vPgrXGJNWHNgA9jDm/ymwGxwoJ9/FT74T x3GH67gKO05/8IsFb5Bhy/ykNusqxH+D+tdjO9mkD1KNKQnUq8+L/tgSsbZC59Zrf/0a t3CIqVVyN+XN8oceFwMOZ6RgiGcmYc4hTkwCjsz2d9S6qZoYDxBYZxdYtckiwK3xpnv3 yfqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748442735; x=1749047535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xr3uS+DPgmCd+/z5aHNgeEzHhg/oAbMGgRViE5pk8dY=; b=bgKy0T6CmQpP0+2HuPCobQgAOjDzrsYqihsP5e5eEhdBlzllYbjOz0BPTz9Rs9qwmh W6F+MEkzqMDvbDLJwmnav/la6/a/dckvNC+OiqbVvw6sPHp9xhSv97Cmu4p0bbZpTjNm RX8zMdHOqTqBpoLjCZPsj3mWAIK6EUY3c8vdXyzLtrtWaFers4oiov6E9E01jeqWNF7g yk78Z3tnPY/Ha+OMvpY6zVMDT2wNlPUDYjhpwSGDm7vBsq8huA5Gfeuw3njtl+uOp399 4MyLe0RxKKyfXGFNjS/MIqXgUSgDz6IxVGTNCmCXnzzK840nJfRfii+XlLXfpPAok5nx l9Sg== X-Gm-Message-State: AOJu0YzEZ4AbvhOvruySJ5kTezYrBbPXJn9r2wmuUk6pxyhoS0bsE/tm eBCzF0bTgdZ1Z2R92TC9/nm5K5YrhP6sRXpBIxVSdO4fxXda0nW/sdeXo8HJLUqHSkQ= X-Gm-Gg: ASbGncue3+MFMITe/hx9bYgs/pZa/p7Zk44I61ckL0K1WLaH1kzyUMw+8o2LYkre++d TCSujUBvn9wHOpi8HGz+TQxFT2B2wWEsGMy5vRrnkh6k5nHY/IlsuaLlVgp+DrctxiKmKeNzgyj l9oNTCKHi0n+bgJUXDCWQmHm5uZ7PyIF4K2WdQ67M06wxVsM62mRjEV+Kknjfs8A3plJvzTsLqH vvuEFHODiJSdCwJ3mkxcEeKVVNraSkctAbWUlQPyNmfW2+w3ILkOr+fYf13LJwzG2Yn2YJCQvB3 DUob+v8Ma9dTPUQbp/p0KvFC+UXv9Gzf1O2p36nw/R89ZqolTSnCOl/NjL9MraMndad2vegFZjz aDo9r3JTGCv4C X-Google-Smtp-Source: AGHT+IGgaXYlQx6FIgwKBiJ5q9YCl+d8hpKt7e9vWDOJINeeWyURDne4ibQvd7rN19CAr28tQ1bJIg== X-Received: by 2002:a05:6000:26d0:b0:3a4:e6d7:6160 with SMTP id ffacd0b85a97d-3a4e6d7ebd2mr2997330f8f.6.1748442734417; Wed, 28 May 2025 07:32:14 -0700 (PDT) Received: from localhost.localdomain ([87.116.163.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4eacd8eeasm1656467f8f.62.2025.05.28.07.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 07:32:13 -0700 (PDT) From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com> To: ffmpeg-devel@ffmpeg.org Date: Wed, 28 May 2025 16:31:53 +0200 Message-ID: <20250528143153.1784-2-ovchinnikov.dmitrii@gmail.com> X-Mailer: git-send-email 2.47.1.windows.1 In-Reply-To: <20250528143153.1784-1-ovchinnikov.dmitrii@gmail.com> References: <20250528143153.1784-1-ovchinnikov.dmitrii@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_d3d12va: added resource Flags support to command line X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250528143153.1784-2-ovchinnikov.dmitrii@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Certain components require ID3D11/ID3D12 textures to be created with additional BindFlags or MiscFlags. FFmpeg currently provides no mechanism to configure these flags externally, leaving no way to satisfy such components without patching the library. This patch adds private device options that can be passed through uav_resource=1 adds D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS render_target_resource=1 adds D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET shared_resource=1 adds D3D12_HEAP_FLAG_SHARED --- libavutil/hwcontext_d3d12va.c | 20 +++++++++++++++++++- libavutil/hwcontext_d3d12va.h | 5 +++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c index 6507cf69c1..67c80c290e 100644 --- a/libavutil/hwcontext_d3d12va.c +++ b/libavutil/hwcontext_d3d12va.c @@ -237,6 +237,9 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size) AVBufferRef *buf; AVD3D12VAFrame *frame; D3D12_HEAP_PROPERTIES props = { .Type = D3D12_HEAP_TYPE_DEFAULT }; + + hwctx->flags |= device_hwctx->flags; + D3D12_RESOURCE_DESC desc = { .Dimension = D3D12_RESOURCE_DIMENSION_TEXTURE2D, .Alignment = 0, @@ -254,7 +257,7 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size) if (!frame) return NULL; - if (FAILED(ID3D12Device_CreateCommittedResource(device_hwctx->device, &props, D3D12_HEAP_FLAG_NONE, &desc, + if (FAILED(ID3D12Device_CreateCommittedResource(device_hwctx->device, &props, device_hwctx->heap_flags, &desc, D3D12_RESOURCE_STATE_COMMON, NULL, &IID_ID3D12Resource, (void **)&frame->texture))) { av_log(ctx, AV_LOG_ERROR, "Could not create the texture\n"); goto fail; @@ -673,6 +676,21 @@ static int d3d12va_device_create(AVHWDeviceContext *hwdev, const char *device, } } + ctx->flags = 0; + + // "shader_resouce" already enabled by default. + + if (av_dict_get(opts, "uav_resource", NULL, 0)) + ctx->flags |= D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS; + + if (av_dict_get(opts, "render_target_resource", NULL, 0)) + ctx->flags |= D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET; + + ctx->heap_flags = D3D12_HEAP_FLAG_NONE; + + if (av_dict_get(opts, "shared_resource", NULL, 0)) + ctx->heap_flags |= D3D12_HEAP_FLAG_SHARED; + return 0; } diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h index 212a6a6146..f1aea52559 100644 --- a/libavutil/hwcontext_d3d12va.h +++ b/libavutil/hwcontext_d3d12va.h @@ -75,6 +75,11 @@ typedef struct AVD3D12VADeviceContext { void (*lock)(void *lock_ctx); void (*unlock)(void *lock_ctx); void *lock_ctx; + /** + * Need to pass value to frames context from command line + */ + D3D12_RESOURCE_FLAGS flags; + D3D12_HEAP_FLAGS heap_flags; } AVD3D12VADeviceContext; /** -- 2.47.1.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".